Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill Vim instance on script exit or not? #20

Open
AndrewRadev opened this issue Apr 11, 2013 · 3 comments
Open

Kill Vim instance on script exit or not? #20

AndrewRadev opened this issue Apr 11, 2013 · 3 comments

Comments

@AndrewRadev
Copy link
Owner

As discussed in #19, there's a lot of sense in providing an option to keep the spawned Vim around after the script has exited. Currently, this works with the :foreground => false option for gvim. It might be a good idea to look into providing similar functionality for headless vim. I also think it might make more sense to have a separate method instead to detach the vim instance from the spawning script.

@moll
Copy link
Contributor

moll commented Aug 23, 2013

That's possibly not a good idea to do automatically. Given that it's most likely to happen via at_exit, it might introduce race conditions if some code, like some test runners today do, runs in an at_exit block. It'll fail if Vimrunner exits in an at_exit prior to that.

@AndrewRadev
Copy link
Owner Author

The Vim instance will be killed automatically upon process exit, since it's a child of that process (as far as I know). The issue discussed in #19 was whether we should make some way to detach the child process, so it stays behind after the script had finished. I don't think using at_exit would be necessary, unless I'm missing something.

@moll
Copy link
Contributor

moll commented Aug 26, 2013

Aah, got it. And it does get killed as a child at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants