This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Halo collector will always revert on sweep #275

Open

stevieraykatz opened this issue Aug 7, 2023 · 0 comments

Labels

Audit

Contributor

stevieraykatz commented Aug 7, 2023

From auditor:

I know halo wasn't in scope but I saw that, so just pointing it out. The contracts/halo/collector/Collector.sol sweep() function is not done apparently:
uint256 amountOut = 0; // TO DO: Need to properly wire up for swaps
uint256 distributeAmount = (amountOut * state.config.rewardFactor) / 100;
That will remain 0 and always revert

stevieraykatz added the Audit label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.