Feat/strapi banner #159
Open
Feat/strapi banner #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ixm-759 is attempting to deploy a commit to the ape-swap-finance Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). apeswap-dex – ./🔍 Inspect: https://vercel.com/ape-swap-finance/apeswap-dex/7PziwWX9JF1Ant3jtzE6gFR6CrfQ |
Apegurus
requested changes
Jun 14, 2021
Comment on lines
+21
to
+27
| export function useSwapBanner() { | ||
| const dispatch = useDispatch<AppDispatch>() | ||
| const banner = getBanner(); | ||
| banner.then((ban) => { | ||
| dispatch(setBanner({ banner: ban })) | ||
| }); | ||
| } |
There was a problem hiding this comment.
I believe this can be improved to be closer to the use we have on the state manager at the farms frontend:
These are good examples of how we use the state manager to load information brought from an API.
Comment on lines
+11
to
+26
| let bannerPromise | ||
|
|
||
| export const fetchBanner = async () => { | ||
| const url = `${baseUrlStrapi}/dexes` | ||
| const resp = await fetch(url) | ||
| const data = await resp.json() | ||
| const poolsList: Banner = data.length > 0 ? data[0] : null | ||
|
|
||
| return poolsList | ||
| } | ||
|
|
||
| export const getBanner = async () => { | ||
| if (!bannerPromise) bannerPromise = fetchBanner() | ||
|
|
||
| return bannerPromise | ||
| } |
There was a problem hiding this comment.
This can probably be improved by refactoring the hook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE DO NOT SUBMIT TOKEN LISTING PULL REQUESTS
All listing requests should be made with this issue template.
Each listing request made as a pull request instead of an issues with the proper template will be ignored and closed.
[ ] Before opening a pull request, please read the contributing guidelines first
[ ] If your PR is work in progress, open it as
draft[ ] Before requesting a review, all the checks need to pass
[ ] Explain what your PR does