Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning if value= is specified for a non payable method [APE-1301] #1610

Open
Aviksaikat opened this issue Aug 19, 2023 · 1 comment
Open
Labels
category: feature New feature or request

Comments

@Aviksaikat
Copy link
Contributor

Aviksaikat commented Aug 19, 2023

Overview

This is similar to #1396. Currently, the proper error message will only trigger when we try to send funds to a non payable constructor. The implementation will be similar to #1599

  • I would like to work on this because soon I will forget how the code works. 😅

Specification

Raising a warning and not an error is better because sometimes you might mean to do this, and it should raise another exception e.g. ContractLogicError or something compiler-specific during gas estimation

Dependencies

N/A

@Aviksaikat Aviksaikat added the category: feature New feature or request label Aug 19, 2023
@vany365 vany365 changed the title Raise warning if value= is specified for a non payable method Raise warning if value= is specified for a non payable method [APE-1301] Aug 19, 2023
@Aviksaikat
Copy link
Contributor Author

Looking into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant