Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Improve visual studio integration on Windows #19

Open
prabhu opened this issue Mar 17, 2020 · 0 comments
Open

Improve visual studio integration on Windows #19

prabhu opened this issue Mar 17, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@prabhu
Copy link
Contributor

prabhu commented Mar 17, 2020

It appears like Visual Studio 2019 with SARIF viewer extension is not working quite well.

  • Visual Studio is expecting the version attribute to be at the top! When we do to_json(sarif schema) the attributes are getting sorted alphabetically so the runs attribute is on the top and version is at the bottom. We need to find a workaround for this
  • Our url encode is encoding and converting the backslash () to %5C thus confusing the extension

Attached is an example.

findsecbugs-report.sarif.txt
@prabhu prabhu added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@prabhu