Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for one-shot cheks #15

Open
MichaelMure opened this issue Oct 18, 2019 · 2 comments
Open

Allow for one-shot cheks #15

MichaelMure opened this issue Oct 18, 2019 · 2 comments

Comments

@MichaelMure
Copy link

MichaelMure commented Oct 18, 2019

Nice little package :-)

In my experience, it's fairly common to expose alongside the health check values some static information about the service, typically the version.

Problem is, the only way to expose those information with go-sundheit is to define a check which means having a ticker refreshing the value. A ticker is not a performance issue but it's still a bit silly. It would be nice if go-sundheit allowed to do that in a less hacky way.

@MichaelMure
Copy link
Author

It could be as simple as allowing to set ExecutionPeriod to zero and not starting the ticker.

@eranharel
Copy link
Contributor

@MichaelMure This is indeed a simple change, but I will make this change only if you think a one-shot check is valuable as a check.

I'm saying that cause think using a health checks library to expose static data feels like a mix of concerns

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants