-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can not navigator with arrow keys #8
Comments
That's weird, this app uses https://github.com/mitsuhiko/dialoguer for the select prompt Could you try a few things to help me pinpoint the origin of this?
It looks like it's maybe not waiting for input, just printing the prompt and exiting which shouldn't happen... |
Same problem here on Ubuntu 20.04, both with gnome-terminal and Tilix. Arrow keys do work on the 1.2.0 release, but not Shift+Enter or Ctrl+Enter. Pressing those just goes into the directory just like pressing Enter without modifiers. |
This sounds like a problem with Maybe it doesn't wait for the program to complete executing Can you try running ls-interactive (v1.3.0) instead of lsi and see if it works? |
Exactly the same bug, it's not even possible to exit with Esc, I have to ^C kill it. |
Thank you, that helps understanding where it might be coming from Since v1.2 works but v1.3 doesn't, It's probably about the new "Fuzzy select" feature I will look into it. If you have rust installed you could try forking the repo and in It's hard for me to debug this, since I'm personally using windows and it works perfectly there :/ |
I just tried this but I got the same bug :( It looks like a terminal problem, as the codes I get on stdout (^[[B, ^[[A…) are uninterpreted terminal escape codes. Let me know if you need to test something else, although I'm not familiar with either Rust or terminal programming so I won't be of much help. |
can you try changing the following in [patch.crates-io]
dialoguer = { git = 'https://github.com/araxeus/dialoguer', branch = 'unix_fix' } (Enabled 'raw mode' before capturing key, might help) (also beware because this will disable ^C for now) if this still doesn't work, I'll try to get a Linux laptop from a friend this weekend and see if I can fix this |
With the unix_fix branch the input issue is solved, at least for arrow keys and using Esc to exit \o/ There are still some issues, I can open new tickets or help you debug in this one:
|
Well I'm glad the original issue is fixed at least 😁
Did you try v1.3.0 and reverted to
I suspect this might be because raw mode is enabled, might have to disable it before # re-rendering the list Also could you confirm that fuzzy select works? (If you type letters - it filters the current list) Thanks a lot for your help ! |
Got my hands on a Linux laptop and fixed most problems in #10 (the installation setup on Linux/Mac changed too) Sadly Ctrl+Enter still doesn't work this is a bug in crossterm, see crossterm-rs/crossterm#669 |
@aztack @marcoil check out https://github.com/Araxeus/ls-interactive/releases/tag/v1.4.0 :) installation method changed too: https://github.com/Araxeus/ls-interactive#linuxmac |
This is great, everything works on my end! Well, except for actually changing into the directory at exit, as I'm using fish and not bash :P Supporting all the Linux variants can be somewhat difficult, so thanks for your efforts. When I get a little time I'll try to provide zsh and fish alternatives. |
I don't actually know how fish behaves, but I think with some slight syntax change it might work: function lsi
set -l output (ls-interactive "$argv")
if [ -n "$output" ]
cd "$output"
end
end if you put this the function just needs to call and for Zsh you should be able to put the original function in |
I hadn't seen your last response, sorry. But I did make an equivalent fish function and put it in pull request #13, in case you want to merge it. Thanks again! |
I tried zsh/bash/fish with iTerm2.app and Terminal.app. None of them works.
The text was updated successfully, but these errors were encountered: