Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build options for deprecated messages MOUNT_CONTROL/MOUNT_CONFIGURE #24743

Merged

Conversation

peterbarker
Copy link
Contributor

Board               AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
Durandal                       *      *           *       *                 *      *      *
HerePro             *                                                                     
Hitec-Airspeed      *                                                                     
KakuteH7-bdshot                *      *           *       *                 *      *      *
MatekF405                      *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot             *                  *       *                 *      *      *
f103-QiotekPeriph   *                                                                     
f303-Universal      *                                                                     
iomcu                                                           *                         
revo-mini                      *      *           *       *                 *      *      *
skyviper-v2450                                    *                                       

I've run this through test_build_options.py for the created defines.

@peterbarker peterbarker force-pushed the pr/defines-for-control-and-command branch from e12c1ff to 27678f0 Compare August 24, 2023 01:55
@peterbarker
Copy link
Contributor Author

We've warned this message isn't supported in 4.3 and 4.4. Maybe for 4.6 we should stop compiling in by default?

@rmackay9
Copy link
Contributor

@peterbarker,

I agree, I'd say that for 4.6 we could delete the code completely. I'd almost be happy doing that for 4.5 but I've just fixed up MP recently (MP PR is here not that it matters)

…NT_CONFIGURE

these are repalced by the command equivalents
…MOUNT_CONFIGURE

these are repalced by the command equivalents
…CONFIGURE

these are repalced by the command equivalents
@peterbarker peterbarker force-pushed the pr/defines-for-control-and-command branch from 27678f0 to a0ccf6d Compare August 24, 2023 12:09
@peterbarker
Copy link
Contributor Author

@peterbarker,

I agree, I'd say that for 4.6 we could delete the code completely. I'd almost be happy doing that for 4.5 but I've just fixed up MP recently (MP PR is here not that it matters)

I'd rather define it out. It gives people the opportunity to jump through some minor hoops to get the functionality back (custom build server or OEM setup or whatever).

But delete in 4.7

@peterbarker peterbarker merged commit 533bc50 into ArduPilot:master Aug 29, 2023
28 checks passed
@peterbarker peterbarker deleted the pr/defines-for-control-and-command branch August 29, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants