Rover: Summarize FALSE's decision

[muramura]

Summarize the judgment that is FALSE.
Judgments are made individually in IF statements.
The judgment result only returns FLASE.

[IamPete1]

Sorry, I think the original way is easier to understand.

[muramura]

@IamPete1 san.
Other methods are doing the same process as mine.

https://github.com/ArduPilot/ardupilot/blob/master/Rover/sailboat.cpp#L285

[peterbarker]

I agree with @IamPete1 ; the current code is far easier to understand.

@muramura the example you cite has no choice but to use a compound expression there - it can't use the "early return pattern". Currently that example is still understandable - but a little more complexity in there and it might be worth breaking out a force_motor_out method or something. Not yet, 'though :-)

Sorry, closing this as it's a step backwards in readability and maintainability.