Rover: Commonly use standardized wording #26989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khancyr
approved these changes
May 31, 2024
|
note that the compiler already does this for us, no flash savings here |
|
up to @rmackay9 |
|
Sorry, I think this arrangement is objectively worse. The text message is being removed from the context in the code where it is being used. The variable does not convey the same information to the programmer as the text. There's no technical advantage at this point. Perhaps if someone wants to change all three at the same time it will save that programmer 15 or 20 seconds?! Sorry, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same message is present in three places.
I make the message variable.
AFTER
