Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new target HolybroF4_PMU #27751

Closed
wants to merge 3 commits into from

Conversation

jamming
Copy link
Contributor

@jamming jamming commented Aug 5, 2024

Add a new target HolybroF4_PMU. It uses STM32F405 MCU and ALLEGRO ACS772 current sensor.

@vincentpoont2
Copy link
Contributor

Hi @peterbarker @tridge , This is for our Holybro DroneCAN Power Module.
we have tested the preset parameter is working with this #27735.

Please review and merge.

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be two commits here.

One for the bootloaders directory, e.g.: bootloaders: add HolybroF4_PMU bootloader
One for the hwdef directory: hwdef: add HolyBroF4_PMU

@Hwurzburg is currently on holidays but does like to review these PRs before they're merged.

@@ -0,0 +1,6 @@
# Enable TYTS03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Enable TYTS03
# Enable TSYS03


## Loading Firmware

You can upgraded the *.bin firmware files using the dronecan GUI tool. *.apj files can also be upgraded using mossionplanner ground station.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can upgraded the *.bin firmware files using the dronecan GUI tool. *.apj files can also be upgraded using mossionplanner ground station.
You can upgrade the *.bin firmware files using the DroneCan GUI tool. *.apj files can also be upgraded using the MissionPlanner ground station.


## Status LED

- Flashing quickly continuously: MCU is in the bootloader stage, waiting for firmware to be flash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Flashing quickly continuously: MCU is in the bootloader stage, waiting for firmware to be flash
- Flashing quickly continuously: MCU is in the bootloader stage, waiting for firmware to be flashed


## Mechanical Spec

- Size: 45mm��41mm��26mm (Not Include Cable)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Size: 45mm��41mm��26mm (Not Include Cable)
- Size: 45mm��41mm��26mm (not including cable)


# blue LED0 marked as ACT
PB0 LED OUTPUT HIGH
define HAL_LED_ON 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this LED will blink at the moment. You need to set things like this now:
define AP_NOTIFY_GPIO_LED_1_ENABLED 1
define AP_NOTIFY_GPIO_LED_1_PIN 90


define DMA_RESERVE_SIZE 0

define HAL_DISABLE_LOOP_DELAY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer used - this line is not effective


define HAL_DISABLE_LOOP_DELAY

define HAL_NO_MONITOR_THREAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line doesn't do anything

@jamming
Copy link
Contributor Author

jamming commented Aug 6, 2024

I have already made all the modifications according to your suggestions.

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Aug 6, 2024
@vincentpoont2
Copy link
Contributor

Hi @peterbarker is it good to merge now?

@peterbarker
Copy link
Contributor

I've created #27998 to replace this.

I was unable to force-push over this branch - probably a repo setting or someone unchecked the "allow force push" option when creating the PR.

The commits needed fixing to conform to our standards - check that other PR to see the shape they need to be.

Please note that the many-repo pattern you're using for these developments is a little vexing to work with as the remote needs to be updated for this sort of tidy-up.

I've marked my other PR as merge-on-ci-pass, so I'm going to close this one.

Thanks!

@peterbarker peterbarker closed this Sep 4, 2024
@peterbarker
Copy link
Contributor

Hi @peterbarker is it good to merge now?

I've merged the PR I created to replace this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WikiNeeded needs wiki update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants