-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_NavEKF2: stop including AP_DAL.h in header #27961
Merged
peterbarker
merged 9 commits into
ArduPilot:master
from
peterbarker:pr/ek2-dal-header-include
Sep 5, 2024
Merged
AP_NavEKF2: stop including AP_DAL.h in header #27961
peterbarker
merged 9 commits into
ArduPilot:master
from
peterbarker:pr/ek2-dal-header-include
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/ek2-dal-header-include
branch
from
September 3, 2024 00:18
df8f634
to
69517e6
Compare
I think we should add a ekf2 enabled build on a ChibiOS board (eg. CubeOrange) in build_ci.sh |
can be merged when we also have a CI check for build with EK2+EK3 on a ChibiOS boards |
peterbarker
force-pushed
the
pr/ek2-dal-header-include
branch
3 times, most recently
from
September 4, 2024 00:49
bb8088d
to
033ad51
Compare
it's not needed and will slow compilation down
We use this library's singleton
we use a method from this library
we instantiate this library in here
need to build at least one ChibiOS-based board to be sure we haven't killed things
peterbarker
force-pushed
the
pr/ek2-dal-header-include
branch
from
September 4, 2024 05:23
033ad51
to
444ef1a
Compare
Added the CI check for EKF2. Now saves a few bytes (optimisation changes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's not needed and will slow compilation down