Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_NavEKF2: stop including AP_DAL.h in header #27961

Merged
merged 9 commits into from
Sep 5, 2024

Conversation

peterbarker
Copy link
Contributor

it's not needed and will slow compilation down

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                 
Durandal                            *      *           *       *                 *      *      *
Hitec-Airspeed           *                                                 
KakuteH7-bdshot                     *      *           *       *                 *      *      *
MatekF405                           *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      *
f103-QiotekPeriph        *                                                 
f303-Universal           *                                                 
iomcu                                                                *     
revo-mini                           *      *           *       *                 *      *      *
skyviper-v2450                                         *                   

@tridge
Copy link
Contributor

tridge commented Sep 3, 2024

I think we should add a ekf2 enabled build on a ChibiOS board (eg. CubeOrange) in build_ci.sh

@tridge
Copy link
Contributor

tridge commented Sep 3, 2024

can be merged when we also have a CI check for build with EK2+EK3 on a ChibiOS boards

@peterbarker peterbarker force-pushed the pr/ek2-dal-header-include branch 3 times, most recently from bb8088d to 033ad51 Compare September 4, 2024 00:49
@peterbarker peterbarker force-pushed the pr/ek2-dal-header-include branch from 033ad51 to 444ef1a Compare September 4, 2024 05:23
@peterbarker
Copy link
Contributor Author

Added the CI check for EKF2. Now saves a few bytes (optimisation changes):

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  0                                                                     
Durandal                            -8     *           -16     -16               -16    -16    -16
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     -72    *           -88     -88               -88    -80    -88
MatekF405                           -56    *           -64     -64               -64    -64    -64
Pixhawk1-1M-bdshot                  -80                -88     -88               -96    -88    -96
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           -56    *           -64     -64               -64    -64    -64
skyviper-v2450                                         -64                                     

@peterbarker peterbarker merged commit adcf5d3 into ArduPilot:master Sep 5, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants