-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log attitude information at full resolution #28008
Conversation
d360699
to
32a4de9
Compare
"a little bit of log bandwidth" sounds a little handy-wavey. Roughly speaking this will double the size of the message. Which will move its proportion of a log from maybe 0.75% to 1.5%, based on the Plane.AUTOTEST log I'm looking at here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to scale targets
32a4de9
to
3aa47e5
Compare
Fixed. I actually think this is much cleaner now. Might even save a little flash. |
3aa47e5
to
c12d5b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fewer cd is good!
c12d5b4
to
098f054
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like the change to log in floats.
But I keep finding these trivial cases where we are breaking ATT
, one of the most important logging messages we have. Please check the log message is correct for all vehicles after your changes.
098f054
to
3073e2d
Compare
3073e2d
to
8d90fb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please state what testing you've given the various vehicles.
8d90fb5
to
6d98038
Compare
I have eyeballed logs from vehicles to check that desired and actual line up. |
@andyp1per with the decision to add an ANG message, do you still want this change? |
I like this change |
We are artificially quantizing the attitude information in the attitude log message. This makes it very hard to relate to the rate logging which is logged at full resolution. There is really no reason to quantize like this other than to save a little bit of log bandwidth.
Split from #27029