Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Terrain: Add const to locals #28734

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Nov 25, 2024

Purpose

Add local const to the AP terrain libraries. Pulled out from another branch.

Why

Signed-off-by: Ryan Friedman <[email protected]>
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Probably best to also clarify what testing has been done

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 25, 2024

I'm flying with this patch in SITL with terrain following enabled. It works (flies without hitting terrain)

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 25, 2024

From durandal:
https://github.com/ArduPilot/ardupilot/actions/runs/12014292966/job/33489748482?pr=28734#step:10:25

Binary Name      Text [B]     Data [B]     BSS (B)      Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  -----------  -----------  -----------  ----------------------------  -------------------------
arducopter-heli  0 (0.0000%)  0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      144768
antennatracker   0 (0.0000%)  0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      614640
arducopter       0 (0.0000%)  0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      144312
ardurover        0 (0.0000%)  0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      298360
arduplane        0 (0.0000%)  0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      146784
blimp            0 (0.0000%)  0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      59[26](https://github.com/ArduPilot/ardupilot/actions/runs/12014292966/job/33489748482?pr=28734#step:10:27)92
ardusub          0 (0.0000%)  0 (0.0000%)  0 (0.0000%)  0 (0.0000%)                                      354100

@peterbarker peterbarker merged commit e7e700d into ArduPilot:master Nov 26, 2024
99 checks passed
@Ryanf55 Ryanf55 deleted the terrain-const branch November 26, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants