Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tabulate dependency #28735

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Add tabulate dependency #28735

merged 1 commit into from
Nov 26, 2024

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Nov 25, 2024 •
edited
Loading

  • Used in filter_size_compare_branches_csv.py

khancyr
khancyr approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Used in some tools by CI too and not a lot of deps so that is as fine as junitparser

khancyr
khancyr suggested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rectification : need to update commit style

@Ryanf55
Tools: Add tabulate dependency
904a86b 
* Used in filter_size_compare_branches_csv

Signed-off-by: Ryan Friedman <[email protected]>
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 25, 2024

rectification : need to update commit style

Fixed

peterbarker
peterbarker approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker peterbarker merged commit a7bbb14 into ArduPilot:master Nov 26, 2024
14 of 15 checks passed
@Ryanf55 Ryanf55 deleted the deps-missing-tabulate branch November 27, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khancyr khancyr khancyr requested changes

@peterbarker peterbarker peterbarker approved these changes

Assignees
No one assigned
Labels
MergeOnCIPass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryanf55 @khancyr @peterbarker