Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndroidX is not supported #204

Closed
ahulyk opened this issue Jun 8, 2018 · 26 comments
Closed

AndroidX is not supported #204

ahulyk opened this issue Jun 8, 2018 · 26 comments

Comments

@ahulyk
Copy link

ahulyk commented Jun 8, 2018

MvpAppCompatFragment extends android.support.v4.app.Fragment and should extends androidx.fragment.app.Fragment to support androidX namespace

@senneco
Copy link
Collaborator

senneco commented Jun 9, 2018

Hi,

I plane to make moxy-android-x module. This allows to use different ways without some conflicts.

@ahulyk
Copy link
Author

ahulyk commented Jun 9, 2018

@senneco hi :)
Cool, thanks!

@VovaStelmashchuk
Copy link
Contributor

I added PR #212 for this issue

@a-solovyev
Copy link

@senneco Hi. Can you merge develop into master and publish Moxy with moxy-androidx module?

@foxwoosh
Copy link

Yes, please. Do it, we are waiting for AndroidX :)

@senneco
Copy link
Collaborator

senneco commented Oct 26, 2018

First we should fix these two issues: https://github.com/Arello-Mobile/Moxy/milestone/1
One is fixed, but still not merged (will make it soon).

@Bendor
Copy link

Bendor commented Nov 9, 2018

@senneco Any news about support androidX?

@victorlapin
Copy link

As a temp workaround, you can use these: https://gitlab.com/victorlapin/flasher/tree/master/src/com/arellomobile/mvp

@foxwoosh
Copy link

Any news?..

@perevetik
Copy link

When? :)

@Xset-s
Copy link

Xset-s commented Jan 25, 2019

When???

@andrey-timofeev
Copy link

When? 🤓

@timuruktus
Copy link

We are waiting for Moxy for androidx :)

@ahulyk
Copy link
Author

ahulyk commented Jan 29, 2019

would be nice to have androidX support in place 👍

@shcherbuk96
Copy link

When?

@VovaStelmashchuk
Copy link
Contributor

I see some people need this feature, I will deploy my fork to maven central on this weekend. My fork has back compatible with Moxy 1.5.5 and support androidX.

@VovaStelmashchuk
Copy link
Contributor

VovaStelmashchuk commented Feb 3, 2019

I deploy my fork to the maven central, with androidX support. I don't finish all feature at the moment. But if you need the support of Andorid X right now. You can check ReadMe file in my fork.
https://github.com/jordan1997/Moxy

@senneco
Copy link
Collaborator

senneco commented Feb 4, 2019

I did moxy specially for independent different modules updates. So, feel free to use standart moxy library and 'tech.schoolhelper:moxy-x-androidx:1.5.6' for andoridx compatibility. Also, you can create other adapters to MvpDelegate (g.e. special wrapper for recycler view).

@kykaparov
Copy link

If you want to wait for official release and migrate anyway to AndroidX, then you can move MvpAppCompatActivity.java, MvpAppCompatDialogFragment.java, MvpAppCompatFragment.java to your project and change the support imports to androidx and refer to this files in your project.

@victorlapin
Copy link

If you want to wait for official release and migrate anyway to AndroidX, then you can move MvpAppCompatActivity.java, MvpAppCompatDialogFragment.java, MvpAppCompatFragment.java to your project and change the support imports to androidx and refer to this files in your project.

Yep, I've posted the link somewhere above. You know, for lazy folks =)

@marinat
Copy link

marinat commented Feb 25, 2019

expect an official release in the main branch?

@luckcoolla
Copy link

any news here?

@olegivo
Copy link

olegivo commented Apr 19, 2019

To work around the issue we can cut out Moxy from our projects...

@ivanessence
Copy link

up problem

@senneco
Copy link
Collaborator

senneco commented May 28, 2019

There is not problem =) Just apply implementation 'tech.schoolhelper:moxy-x-material:1.7.0'

@senneco senneco closed this as completed May 28, 2019
@pavelpoley
Copy link

can someone help
#258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests