Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to run when loading an incompatible plugin #259

Open
SuperFola opened this issue May 29, 2021 · 0 comments
Open

Failing to run when loading an incompatible plugin #259

SuperFola opened this issue May 29, 2021 · 0 comments
Labels
ark/virtual machine Related to the ark virtual machine 🔥 bug Something isn't working ❗️ priority/medium

Comments

@SuperFola
Copy link
Member

In the VM, we have an instruction to load plugins (.dll, .so and .dynlib, depending on the OS), working perfectly when Ark and the plugin have been compiled with the same compiler and the same compilation options (both debug or both release).

A problem occurs when we use a debug plugin with a release ark: ark silently fails to load it, throwing an exception we aren't catching / interpreting as "bad plugin".

This should be investigated to be able to tell the user that the plugin couldn't be loaded, and we should abort execution (no plugin loaded => undefined symbols later on, coming from the plugin we didn't load, thus can not execute: better to abort to give a clear error message).

This problem will mostly be encountered by our contributors and development team, as our end users are only being provided the final binaries, which we should test before publishing. When developing we sometimes forget to recompile everything, and it's really annoying because we start searching for a bug in the VM while it's just a target to recompile.

@SuperFola SuperFola added 🔥 bug Something isn't working ark/virtual machine Related to the ark virtual machine ❗️ priority/medium labels May 29, 2021
@SuperFola SuperFola added this to the 3.2.0 milestone May 29, 2021
@SuperFola SuperFola modified the milestones: 3.2.0, 3.3.0 Aug 7, 2021
@SuperFola SuperFola removed this from the 3.3.0 milestone Mar 24, 2022
@SuperFola SuperFola moved this to v3.5.0 in [public] Road to v4 Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ark/virtual machine Related to the ark virtual machine 🔥 bug Something isn't working ❗️ priority/medium
Projects
Status: v3.5.0
Development

No branches or pull requests

1 participant