Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the import method of the parser #261

Closed
SuperFola opened this issue Jun 2, 2021 · 1 comment
Closed

Refactor the import method of the parser #261

SuperFola opened this issue Jun 2, 2021 · 1 comment

Comments

@SuperFola
Copy link
Member

import acts like a macro: read filename, canonicalize it (our reference path being the path of the first file) can check if it's in our already imported files list. The way we handle the already imported files is ugly, we are synchronizing the current parser's and new parser's import lists, with some magic code on top of that to handle the root file path.

An idea could be to share a structure (through raw pointer) managed by the caller (the compiler) to store those informations to be cleaner.

@SuperFola SuperFola added this to the 3.2.0 milestone Jun 2, 2021
@SuperFola SuperFola modified the milestones: 3.2.0, 3.3.0 Aug 7, 2021
@SuperFola SuperFola removed this from the 3.3.0 milestone Mar 24, 2022
@SuperFola SuperFola moved this to v3.6.0 in [public] Road to v4 Jul 17, 2022
@SuperFola
Copy link
Member Author

Closing this since it will be handled by #425 thanks to the new parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: v3.6.0
Development

No branches or pull requests

1 participant