New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: bad condition when checking args type #58

Open

SuperFola opened this issue Aug 6, 2024 · 0 comments

Labels

bug

Member

SuperFola commented Aug 6, 2024

modules/draft/http/src/client.cpp

Line 132 in e3627a0

if (n[2].valueType() != ValueType::String ||

We should have a && between isString/(isUser||isParams) instead of ||, because it shortcircuits when it isn't a string and generate the error.

SuperFola added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment