Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch nlohmann/json for rapidjson #59

Open
SuperFola opened this issue Nov 23, 2024 · 0 comments
Open

Switch nlohmann/json for rapidjson #59

SuperFola opened this issue Nov 23, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed priority/medium

Comments

@SuperFola
Copy link
Member

We would like to switch to rapidjson (MIT) for the json module, instead of nlohmann/json.

Boost would be faster, but an MIT license is better (benchmarks: https://230.jsondocs.prtest.cppalliance.org/libs/json/doc/html/json/benchmarks.html).

The module API shouldn't change, however more functions could be added, depending on the needs. Tests should pass, more can be added (because we never have enough tests).

The json submodule will have to be removed, rapidjson could be installed through CPM.

@SuperFola SuperFola added good first issue Good for newcomers help wanted Extra attention is needed priority/medium labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed priority/medium
Projects
None yet
Development

No branches or pull requests

1 participant