Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Configs #3

Open
ArunVenkata opened this issue Oct 16, 2024 · 0 comments
Open

Add Support for Configs #3

ArunVenkata opened this issue Oct 16, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ArunVenkata
Copy link
Owner

ArunVenkata commented Oct 16, 2024

Add support for generating the url based on configs (Ex. staging, production, demo)

Should reference specifications from the .ghprrc file

An example file would be as follows:

[defaults]
... # default parameters

[config:production]
dest="master"
title="Production Merge: "

[config:staging]
dest="staging"
title="Staging Merge: "

The command could be ghpr --config production (Open to Suggestions!)

Note: It should support adding all other parameters as well, which(if specified) would take preference over the ones present in the .ghprrc file

To save your time and mine, DO NOT start your implementation without discussing your approach in this forum first.

A good PR would include:

  • Feature Implementation
  • Relevant Tests
  • Updates to documentation
@ArunVenkata ArunVenkata added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Hacktoberfest and removed good first issue Good for newcomers labels Oct 16, 2024
@ArunVenkata ArunVenkata removed the hacktoberfest Hacktoberfest label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant