From 8c6e2e696eb78cd3956229409cf92605563bd492 Mon Sep 17 00:00:00 2001
From: yingfeng-iu <yingfeng@iu.edu>
Date: Fri, 10 Nov 2023 17:49:25 -0500
Subject: [PATCH 1/5] AMP-2826 - remove unncessary AC - improve refresh tole
 flag - fix a few places in search

---
 src/components/entity/EntityList.vue | 12 +++--
 src/components/shared/Search.vue     | 66 ++++++++++++----------------
 2 files changed, 33 insertions(+), 45 deletions(-)

diff --git a/src/components/entity/EntityList.vue b/src/components/entity/EntityList.vue
index 4c56cc99..48e3f7ec 100644
--- a/src/components/entity/EntityList.vue
+++ b/src/components/entity/EntityList.vue
@@ -1284,8 +1284,6 @@ export default {
         JSON.stringify({ ...self.unitEntity })
       );
       self.getData();
-      self.assignedRolesUnitChanged = true;
-      self.settingsRolesUnitChanged = true;
       //Checking Access Control
       self.accessControlService.checkAccessControl(this);
     },
@@ -1342,7 +1340,9 @@ export default {
     async getData() {
       const self = this;
       if (self.baseUrl === "unit") {
-        this.getUnitDetails();
+        self.getUnitDetails();
+        self.assignedRolesUnitChanged = true;
+        self.settingsRolesUnitChanged = true;
       } else if (self.baseUrl === "collection") {
         self.entity = self.selectedCollection;
         if (self.selectedCollection && !self.isCreatePage)
@@ -1494,8 +1494,8 @@ export default {
     
     // TODO below checkAccessControl is unnecessary because it's done upon each unit change
     // including change made in item search
-    if (uEntity && uEntity.currentUnit)
-      self.accessControlService.checkAccessControl(this);
+    // if (uEntity && uEntity.currentUnit)
+    //   self.accessControlService.checkAccessControl(this);
 
     if (!uEntity) { //} && !self.selectedUnit) {
       self.unitEntity = { unitList: [], currentUnit: "" };
@@ -1503,8 +1503,6 @@ export default {
     } else {
       self.unitEntity = uEntity;
       self.getData();
-      self.assignedRolesUnitChanged = true;
-      self.settingsRolesUnitChanged = true;
     }
 
     let formHTML = document.getElementsByClassName("form")[0];
diff --git a/src/components/shared/Search.vue b/src/components/shared/Search.vue
index a9d82699..cdfdfdfe 100644
--- a/src/components/shared/Search.vue
+++ b/src/components/shared/Search.vue
@@ -841,7 +841,8 @@ export default {
         self.selectedItemId = record.id;
         self.selectedUnit = {};
         self.selectedUnit.name = record.unitName;
-        self.selectedCollection = record.collectionName;
+        self.selectedCollection = {};
+        self.selectedCollection.name = record.collectionName;
         return;
       }
       // console.log(self.selectAll);
@@ -1018,48 +1019,37 @@ export default {
               : []
           );
           break;
-        case "item-search":
+        case "item-search":          
           this.itemService
             .getItemDetails(this.selectedItemId)
             .then((res) => {
+              const self = this;
               const selectedCollectionId = res._embedded.collection.id;
-              this.itemService
-                .getItemById(selectedCollectionId, this.selectedItemId)
+              self.collectionDetailsService
+                .getCollection(selectedCollectionId)
                 .then((response) => {
-                  const self = this;
-                  self.collectionDetailsService
-                    .getCollection(selectedCollectionId)
-                    .then((response) => {
-                      self.selectedCollection = response.data;
-
-                      //Updating unit id in our session storage for content page
-                      const unitId = response.data._embedded.unit.id;
-                      let uEntity = JSON.parse(
-                        sessionStorage.getItem("unitEntity")
-                      );
-                      console.log("Search: uEntity = " + uEntity);
-                      // if (!uEntity) {
-                      //   sessionStorage.setItem("unitEntity",
-                      //     JSON.stringify({ ...self.unitEntity })
-                      //   );
-                      uEntity.currentUnit = unitId;
-                      sessionStorage.setItem(
-                        "unitEntity",
-                        JSON.stringify({ ...uEntity })
-                      );
-
-                      //checking permission
-                      if (uEntity && uEntity.currentUnit)
-                        self.accessControlService.checkAccessControl(self);
-                    });
-
-                  const res = JSON.parse(JSON.stringify(response));
-                  self.selectedItem = res;
-                  self.selectedItem.parentType = self.type;
-                  self.selectedItem.unitName = self.selectedUnit.name;
-                  self.selectedItem.collectionName = self.selectedCollection;
-                  self.$router.push("/collections/items/item-search/details");
-                });
+                  self.selectedCollection = response.data;
+                  //Updating unit id in our session storage for content page
+                  const unitId = response.data._embedded.unit.id;
+                  let uEntity = JSON.parse(
+                    sessionStorage.getItem("unitEntity")
+                  );
+                  uEntity = uEntity || {};
+                  console.log("Search: uEntity = " + uEntity);
+                  uEntity.currentUnit = unitId;
+                  sessionStorage.setItem(
+                    "unitEntity",
+                    JSON.stringify({ ...uEntity })
+                  );
+                  //checking permission
+                  if (uEntity && uEntity.currentUnit)
+                    self.accessControlService.checkAccessControl(self);
+                });                  
+              self.selectedItem = res;
+              self.selectedItem.parentType = self.type;
+              self.selectedItem.unitName = self.selectedUnit.name;
+              self.selectedItem.collectionName = self.selectedCollection.name;
+              self.$router.push("/collections/items/item-search/details");
             })
             .catch((error) => {
               this.dataSource = [];

From f10f25f0cdebcc433de496babe3925937404fb40 Mon Sep 17 00:00:00 2001
From: yingfeng <yingfeng@iu.edu>
Date: Mon, 13 Nov 2023 15:02:17 -0500
Subject: [PATCH 2/5] AMP-3091/2826 - remove unnessary API calls in Index that
 caused 401 - fixed a few potential bugs in EntityList regarding uEntity - add
 logs to router - TODO item in account-serivce

---
 src/components/account/ForgotPassword.vue |  2 +-
 src/components/entity/EntityList.vue      | 23 ++++++++++++++++++++---
 src/components/home/index.vue             | 19 -------------------
 src/router.js                             |  8 +++++---
 src/service/account-service.js            |  5 +++++
 5 files changed, 31 insertions(+), 26 deletions(-)

diff --git a/src/components/account/ForgotPassword.vue b/src/components/account/ForgotPassword.vue
index 853bfc8c..4e12bedf 100644
--- a/src/components/account/ForgotPassword.vue
+++ b/src/components/account/ForgotPassword.vue
@@ -47,7 +47,7 @@
               </p>
 
               <div class="form-group" v-if="resend_email">
-                <label>An email has been sent. </label>
+                <label>An email with a link to reset password has been sent.  </label>
                 <span><a href="#" @click="sendEmail()">Resend Email?</a></span>
               </div>
             </form>
diff --git a/src/components/entity/EntityList.vue b/src/components/entity/EntityList.vue
index 48e3f7ec..63e43fe6 100644
--- a/src/components/entity/EntityList.vue
+++ b/src/components/entity/EntityList.vue
@@ -1401,6 +1401,7 @@ export default {
     },
     async getCollectionItems() {
       const self = this;
+      self.showLoader = true;
       self.itemService
         .getCollectionItems(self.selectedCollection.id)
         .then((response) => {
@@ -1412,6 +1413,7 @@ export default {
             self.masterRecords = JSON.parse(JSON.stringify(self.records));
           }
         });
+        self.showLoader = false;
     },
     async onView(objInstance) {
       const self = this;
@@ -1497,11 +1499,26 @@ export default {
     // if (uEntity && uEntity.currentUnit)
     //   self.accessControlService.checkAccessControl(this);
 
-    if (!uEntity) { //} && !self.selectedUnit) {
+    // if (!uEntity) { //} && !self.selectedUnit) {
+    //   self.unitEntity = { unitList: [], currentUnit: "" };
+    //   self.getAllUnits();
+    // } else {
+    //   self.unitEntity = uEntity;
+    //   self.getData();
+    // }
+
+    if (!uEntity) {
       self.unitEntity = { unitList: [], currentUnit: "" };
+    }
+    else {
+      self.unitEntity = uEntity;    
+    }
+
+    if (!self.unitEntity.unitList || !self.unitEntity.unitList.length) {
       self.getAllUnits();
-    } else {
-      self.unitEntity = uEntity;
+    } 
+
+    if (self.unitEntity.currentUnit) {
       self.getData();
     }
 
diff --git a/src/components/home/index.vue b/src/components/home/index.vue
index dd7edc4a..3f30d25f 100644
--- a/src/components/home/index.vue
+++ b/src/components/home/index.vue
@@ -1,6 +1,5 @@
 <template>
   <div class="w-100 home-container">
-    <loader :show="loading" />
 
     <div class="home tech-bg  ex-lg">
       <div class="home-body">
@@ -45,24 +44,16 @@
 <script>
 import { sync } from "vuex-pathify";
 import { env } from "@/helpers/env";
-import Loader from "@/components/shared/Loader.vue";
 import config from "@/assets/constants/common-contant.js";
 import SharedService from "@/service/shared-service";
-import EvaluationService from "@/service/evaluation-service";
-import ConfigPropertiesService from "@/service/config-properties-service";
 
 export default {
   name: "Home",
   components: {
-    Loader,
   },
   data() {
     return {
-      loading: false,
       cardList: config.cards,
-      sharedService: new SharedService(),
-      evaluationService: new EvaluationService(),
-      configPropertiesService: new ConfigPropertiesService(),
     };
   },
   props: {},
@@ -73,18 +64,8 @@ export default {
       if (envKey === "VUE_APP_DOC_AMP_MAIL_TO") window.location.href = url;
       else window.open(url, "helpwindow", "width=800, height=500");
     },
-    async networkCalls() {
-      const self = this;
-      try {
-        const configPropertiesResponse = await self.configPropertiesService.getConfigProperties();
-        self.configProperties = configPropertiesResponse.data;
-      } catch (error) {
-        console.log(error);
-      }
-    },
   },
   mounted() {
-    this.networkCalls();
   },
 };
 </script>
diff --git a/src/router.js b/src/router.js
index b8c146dc..a12adb51 100644
--- a/src/router.js
+++ b/src/router.js
@@ -478,10 +478,11 @@ router.beforeEach(async (to, from, next) => {
   const currentUser = accountService.currentUserValue;
 
   if (env.getDisableAuth() == "true" || !authorize) {
+	  console.log("router: No auth needed.")
     return next();
   } else if (!currentUser) {
-    console.log("Current user not logged in yet.");
-    // not logged in so redirect to login page with the return url
+    console.log("router: Current user not logged in yet.");
+    // not logged in so redirect to access-denied page with login link and with the return url
     return router.push({ path: "/access-denied", query: { returnUrl: to.path }});
   } else {
     // TODO, below API call is to validate auth token, in case the locally stored one is compromised;
@@ -491,6 +492,7 @@ router.beforeEach(async (to, from, next) => {
       // return next();
       router.app.$store.state.isAuthenticated = false;
       router.app.$store.commit("isAuthenticated");
+      console.log("router: Auth token invalid!")
       return next({ path: "/account/login", query: { returnUrl: to.path } });
     } else {
       router.app.$store.state.isAuthenticated = true;
@@ -498,7 +500,7 @@ router.beforeEach(async (to, from, next) => {
       // let acActions = router.app.$store.state.acActions;
       let acActions = store.state.acActions;
       let acIsAdmin = store.state.acIsAdmin;
-      console.log("initPermissions =  ", acActions," isAdmin = ", acIsAdmin);
+      console.log("router: initPermissions =  ", acActions," isAdmin = ", acIsAdmin);
       if (acActions.includes(action) || acIsAdmin) {
         console.log(currentUser.username + " can perform action " + action);
         return next();
diff --git a/src/service/account-service.js b/src/service/account-service.js
index f36ba2ba..a96479df 100644
--- a/src/service/account-service.js
+++ b/src/service/account-service.js
@@ -2,6 +2,11 @@ import BaseService from './base-service.js';
 
 const currentUser = JSON.parse(localStorage.getItem('currentUser'));
 const baseService = new BaseService();
+
+// TODO
+// API calls for user registration & reset password etc should not use post_auth as 
+// these APIs do not require authentication; instead just use plain baseService.post
+
 function sendRegisterRequest(username, firstName, lastName, pswd, email) {
   const url = `/account/register`;
 	return baseService.post_auth(url,

From 6a2972ff831f56bc7e1bc58bbc7c9012acc40145 Mon Sep 17 00:00:00 2001
From: yingfeng <yingfeng@iu.edu>
Date: Wed, 15 Nov 2023 09:23:52 -0500
Subject: [PATCH 3/5] AMP-2826/2226 - add space for resend on ForgotPassword
 page - add logs to router

---
 src/components/account/ForgotPassword.vue | 4 ++--
 src/router.js                             | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/components/account/ForgotPassword.vue b/src/components/account/ForgotPassword.vue
index 4e12bedf..43763b71 100644
--- a/src/components/account/ForgotPassword.vue
+++ b/src/components/account/ForgotPassword.vue
@@ -47,8 +47,8 @@
               </p>
 
               <div class="form-group" v-if="resend_email">
-                <label>An email with a link to reset password has been sent.  </label>
-                <span><a href="#" @click="sendEmail()">Resend Email?</a></span>
+                <label>An email with a link to reset password has been sent.</label>
+                <span><a href="#" @click="sendEmail()">&nbsp; Resend Email</a></span>
               </div>
             </form>
           </div>
diff --git a/src/router.js b/src/router.js
index a12adb51..50f25d8d 100644
--- a/src/router.js
+++ b/src/router.js
@@ -36,7 +36,6 @@ var router = new Router({
       name: "home",
       component: HomePage,
       meta: {
-        // authorize: [],
         helpUrl: env.getEnv("VUE_APP_DOC_AMP_USER_GUIDE"),
       },
     },
@@ -477,6 +476,8 @@ router.beforeEach(async (to, from, next) => {
   const { authorize } = to.meta;
   const currentUser = accountService.currentUserValue;
 
+  console.log("from: ", from, "\nto: ", to, "\nnext: ", next);
+
   if (env.getDisableAuth() == "true" || !authorize) {
 	  console.log("router: No auth needed.")
     return next();

From 50232cb020a05c1174082897bc7d909d6c89a265 Mon Sep 17 00:00:00 2001
From: yingfeng <yingfeng@iu.edu>
Date: Wed, 15 Nov 2023 09:32:41 -0500
Subject: [PATCH 4/5] AMP-2226: improve reset pw msg

---
 src/components/account/ForgotPassword.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/account/ForgotPassword.vue b/src/components/account/ForgotPassword.vue
index 43763b71..b5c34173 100644
--- a/src/components/account/ForgotPassword.vue
+++ b/src/components/account/ForgotPassword.vue
@@ -47,7 +47,7 @@
               </p>
 
               <div class="form-group" v-if="resend_email">
-                <label>An email with a link to reset password has been sent.</label>
+                <label>An email with a link to reset password has been sent. Please use the link as soon as possible as it will expire in s short time.</label>
                 <span><a href="#" @click="sendEmail()">&nbsp; Resend Email</a></span>
               </div>
             </form>

From 203036cd9641eeac598c64dac584f563476f8273 Mon Sep 17 00:00:00 2001
From: yingfeng <yingfeng@iu.edu>
Date: Wed, 15 Nov 2023 09:46:27 -0500
Subject: [PATCH 5/5] AMP-3092: replace fontawesome line which causes 403

---
 public/index.html | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/public/index.html b/public/index.html
index 5e39e42f..e4e4e168 100644
--- a/public/index.html
+++ b/public/index.html
@@ -11,10 +11,11 @@
     <link rel="stylesheet" type="text/css" href="/css/style.css">
     <link rel="icon" href="<%= BASE_URL %>favicon.ico">
     <link href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;700&display=swap" rel="stylesheet">
+    <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.1.1/css/all.min.css" />
     <title>AMP</title>
     <style> body {margin:0px} </style>
     <script>window.AG_AdblockGlobalEnabled = true;</script>
-    <script src="https://kit.fontawesome.com/a076d05399.js"></script>
+    <!-- <script src="https://kit.fontawesome.com/a076d05399.js"></script> -->
     <script type="text/javascript">
       var cachebuster = Math.round(new Date().getTime() / 1000);
       document.write('<scr' + 'ipt type="text/javascript" src="./config.js?cb=' + cachebuster + '"></scr' + 'ipt>');