Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme instructions for creating a PR from another fork #96

Open
david-pfx opened this issue Apr 16, 2023 · 0 comments
Open

Readme instructions for creating a PR from another fork #96

david-pfx opened this issue Apr 16, 2023 · 0 comments

Comments

@david-pfx
Copy link

david-pfx commented Apr 16, 2023

The README says:

To make a PR when you already have a fork of vanilla PS:
    Locally, add PuzzleScript Plus as an origin in your PuzzleScript repository.
    Fetch and check out a branch from PuzzleScript Plus (likely develop unless instructed otherwise).
    Now you can commit there, push it, and use that branch for PRs!

It's not made clear that you have to first push a PR branch to your own fork, and then raise the PR from your fork to PS+.

The steps I suggest are:

  • Develop your changes locally, using either a clone of PS+ or a branch checked out from PS+.
  • Locally, make both your fork and PS+ remotes of your local repo.
  • Commit your changes locally onto a new branch that will become the PR. Give it a nice name including 'pr' and the issue number eg pr-psplus-#9999
  • Push the branch to your fork on GitHub.
  • Raise the PR on that branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant