You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not sure about this one yet, but on PropertyReader: getKeys and getChildKeys is not used by ConfigMe, and I've been throwing UnsupportedOperationException in custom reader implementations I've created. It might be nicer to introduce an extension to PropertyReader and have the existing YamlFileReader implement it, so that whoever needs the child keys can get them, without having to create the methods if they're not of interest. ConfigMe doesn't need them anywhere.
Interestingly, with the new property type implementations, we don't need any methods except contains and getObject. The question is whether we should also drop getBoolean and friends, or provide default methods for them... I think keeping the methods is not so bad, since they're useful in the migration service. Then again, the best way to get old values from the reader is to create a new Property in the method and to extract values like that.
The text was updated successfully, but these errors were encountered:
Not sure about this one yet, but on PropertyReader:
getKeys
andgetChildKeys
is not used by ConfigMe, and I've been throwingUnsupportedOperationException
in custom reader implementations I've created. It might be nicer to introduce an extension to PropertyReader and have the existing YamlFileReader implement it, so that whoever needs the child keys can get them, without having to create the methods if they're not of interest. ConfigMe doesn't need them anywhere.Interestingly, with the new property type implementations, we don't need any methods except
contains
andgetObject
. The question is whether we should also dropgetBoolean
and friends, or provide default methods for them... I think keeping the methods is not so bad, since they're useful in the migration service. Then again, the best way to get old values from the reader is to create a new Property in the method and to extract values like that.The text was updated successfully, but these errors were encountered: