Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Checkstyle version from 8.39 to 10.7.0 #442

Closed
ljacqu opened this issue Oct 5, 2024 · 1 comment
Closed

Update Checkstyle version from 8.39 to 10.7.0 #442

ljacqu opened this issue Oct 5, 2024 · 1 comment
Milestone

Comments

@ljacqu
Copy link
Member

ljacqu commented Oct 5, 2024

We currently run Checkstyle in CodeClimate, meaning the version of the Checkstyle rules needs to be in sync with what CodeClimate uses. It's not updated frequently, and now IntelliJ doesn't even have such old versions of Checkstyle.

Goal of this issue is to update to a newer version of Checkstyle by using another "channel" in CodeClimate:
https://github.com/codeclimate/codeclimate-checkstyle/tree/channel/checkstyle-10-7-0

It should be possible to specify the channel in .codeclimate.yml by adding a property channel: "checkstyle-10-7-0" to the Checkstyle check (search for "beta" in https://docs.codeclimate.com/docs/checkstyle to see how)

To do

  • Change channel to checkstyle-10-7-0 in .codeclimate.yml for the Checkstyle plugin
  • Migrate .checkstyle.yml to the proper format for Checkstyle 10.7.0
  • Update the comment in .checkstyle.yml to not mention 8.39 anymore
@ljacqu ljacqu added the good-first-issue Want to contribute? This label marks well-defined, [relatively] straightforward issues label Oct 5, 2024
@ljacqu ljacqu changed the title Update Checkstyle version Update Checkstyle version from 8.39 to 10.7.0 Oct 5, 2024
@ljacqu
Copy link
Member Author

ljacqu commented Oct 5, 2024

For what it's worth, the long-term goal is probably to ditch CodeClimate if there's a suitable alternative for Sonar/Checkstyle, cf. #376

ljacqu added a commit that referenced this issue Oct 5, 2024
* #442 Update Checkstyle version used by CodeClimate

* Move channel declaration
@ljacqu ljacqu added this to the 2.0.0 milestone Oct 5, 2024
@ljacqu ljacqu removed the good-first-issue Want to contribute? This label marks well-defined, [relatively] straightforward issues label Oct 5, 2024
@ljacqu ljacqu closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant