Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Junit being pulled in as transitive dependency in compile scope #188

Open
SalesforceBrian opened this issue Dec 14, 2021 · 0 comments · May be fixed by #189
Open

Junit being pulled in as transitive dependency in compile scope #188

SalesforceBrian opened this issue Dec 14, 2021 · 0 comments · May be fixed by #189

Comments

@SalesforceBrian
Copy link

SalesforceBrian commented Dec 14, 2021 •
edited
Loading

log4j-1.2-api and log4j-api are pulling JUnit in as a transitive dependency in the compile scope. This causes a problem for me as the version of JUnit pulled in has security & license issues that prevent it being deployed in my env.

Since JUnit shouldn't be in the compile scope anyway, and this SDK already explicitly pulls JUnit in to the testscope, we should exclude JUnit from the log4j-1.2-api and log4j-api dependencies
@SalesforceBrian SalesforceBrian linked a pull request Dec 14, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude junit from compile scope (fixes #188) SalesforceBrian/sdk-java
1 participant
@SalesforceBrian