From 6e2517d6db7152ddd52db789189c57248991723c Mon Sep 17 00:00:00 2001 From: Dean Sas Date: Tue, 3 Sep 2024 17:35:13 +0100 Subject: [PATCH] Change design task for Writing and Free flows (#39189) The Write and Free launchpad checklists used the `design_selected` task in their launchpad definitions. This task is always marked as done, even if a design isn't actually selected, which is perfectly possible for both of these flows - even likely for the write flow, depending upon the precise path. Now they use the `design_completed` task, which explicitly checks whether a design has been selected before being marked as completed. --- .../jetpack-mu-wpcom/changelog/update-launchpad-design-done | 4 ++++ .../jetpack-mu-wpcom/src/features/launchpad/launchpad.php | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 projects/packages/jetpack-mu-wpcom/changelog/update-launchpad-design-done diff --git a/projects/packages/jetpack-mu-wpcom/changelog/update-launchpad-design-done b/projects/packages/jetpack-mu-wpcom/changelog/update-launchpad-design-done new file mode 100644 index 0000000000000..7d0d8069019f2 --- /dev/null +++ b/projects/packages/jetpack-mu-wpcom/changelog/update-launchpad-design-done @@ -0,0 +1,4 @@ +Significance: patch +Type: changed + +Launchpad: Require a design is selected before marking the step as complete in both the Write and Free flows diff --git a/projects/packages/jetpack-mu-wpcom/src/features/launchpad/launchpad.php b/projects/packages/jetpack-mu-wpcom/src/features/launchpad/launchpad.php index 47decac0cc005..829e09765d6a2 100644 --- a/projects/packages/jetpack-mu-wpcom/src/features/launchpad/launchpad.php +++ b/projects/packages/jetpack-mu-wpcom/src/features/launchpad/launchpad.php @@ -52,7 +52,7 @@ function wpcom_launchpad_get_task_list_definitions() { 'task_ids' => array( 'plan_selected', 'setup_free', - 'design_selected', + 'design_completed', 'domain_upsell', 'first_post_published', 'design_edited', @@ -120,7 +120,7 @@ function wpcom_launchpad_get_task_list_definitions() { }, 'task_ids' => array( 'setup_write', - 'design_selected', + 'design_completed', 'plan_selected', 'first_post_published', 'site_launched',