From b316888fb52c4166be595dda24dd387751584f33 Mon Sep 17 00:00:00 2001 From: Brad Jorsch Date: Tue, 23 Jul 2024 15:40:44 -0400 Subject: [PATCH] lazy-images: Mark package as abandoned WordPress Core has been outputting the necessary attributes for browser-native lazy image loading for some time now, and it conflicts with the new Interactivity API added by Gutenberg in 16.6. We've removed use of it from both Jetpack and Boost. Let's finish the job by marking it as deprecated, and then we can do a final release and remove it from the monorepo. --- docs/monorepo.md | 4 ++-- projects/packages/lazy-images/README.md | 3 +++ .../lazy-images/changelog/update-abandon-lazy-images-package | 4 ++++ projects/packages/lazy-images/composer.json | 3 ++- 4 files changed, 11 insertions(+), 3 deletions(-) create mode 100644 projects/packages/lazy-images/changelog/update-abandon-lazy-images-package diff --git a/docs/monorepo.md b/docs/monorepo.md index a6a634c8a2b0d..f2bd53c0b6f1f 100644 --- a/docs/monorepo.md +++ b/docs/monorepo.md @@ -125,8 +125,8 @@ We use `composer.json` to hold metadata about projects. Much of our generic tool * `.extra.autotagger`: Set truthy to enable automatic release-version tagging in the mirror repo. See [Mirror repositories > Autotagger](#autotagger) for details. * `.extra.changelogger`: Configuration object for [Changelogger](#jetpack-changelogger). See [its documentation](https://github.com/Automattic/jetpack-changelogger#configuration) for details. * `.extra.changelogger-default-type`: Certain of our tools automatically create Changelogger change entries. This is the value to use for `--type` when doing so. Default type is `changed`. -* `.extra.dependencies.build`: This optional array specifies the "slugs" of any within-monorepo build dependencies that can't otherwise be inferred. The "slug" consists of the two levels of directory under `projects/`, e.g. `plugins/jetpack` or `packages/lazy-images`. -* `.extra.dependencies.test`: This optional array specifies the "slugs" of any within-monorepo testing dependencies that can't otherwise be inferred. The "slug" consists of the two levels of directory under `projects/`, e.g. `plugins/jetpack` or `packages/lazy-images`. See [Testing](#testing) for details. +* `.extra.dependencies.build`: This optional array specifies the "slugs" of any within-monorepo build dependencies that can't otherwise be inferred. The "slug" consists of the two levels of directory under `projects/`, e.g. `plugins/jetpack` or `packages/changelogger`. +* `.extra.dependencies.test`: This optional array specifies the "slugs" of any within-monorepo testing dependencies that can't otherwise be inferred. The "slug" consists of the two levels of directory under `projects/`, e.g. `plugins/jetpack` or `packages/changelogger`. See [Testing](#testing) for details. * `.extra.dependencies.test-only`: This optional array specifies the "slugs" of any within-monorepo dependencies that are only used for testing and/or static analysis and should be ignored otherwise when analyzing intra-monorepo dependencies. * `.extra.dev-releases`: Indicate that the plugin will have developer alpha releases. Instead of the mirror repositories showing "VER-alpha", they'll start at "VER-a.0" and you can use the `-a` flag to the release tooling to release "VER-a.1". * `.extra.mirror-repo`: This specifies the name of the GitHub mirror repo, i.e. the "Automattic/jetpack-_something_" in "https://github.com/Automattic/jetpack-_something_". diff --git a/projects/packages/lazy-images/README.md b/projects/packages/lazy-images/README.md index edf39c5188cd0..3e34477b9479b 100644 --- a/projects/packages/lazy-images/README.md +++ b/projects/packages/lazy-images/README.md @@ -2,6 +2,9 @@ Speed up your site and create a smoother viewing experience by loading images as visitors scroll down the screen, instead of all at once. +> [!CAUTION] +> This package is abandoned. WordPress Core now uses browsers' native lazy loading, and the code in here conflicts with the Interactivity API added in Gutenberg 16.6. + ## Usage ```php diff --git a/projects/packages/lazy-images/changelog/update-abandon-lazy-images-package b/projects/packages/lazy-images/changelog/update-abandon-lazy-images-package new file mode 100644 index 0000000000000..872868d03bf26 --- /dev/null +++ b/projects/packages/lazy-images/changelog/update-abandon-lazy-images-package @@ -0,0 +1,4 @@ +Significance: patch +Type: deprecated + +Mark package as abandoned. diff --git a/projects/packages/lazy-images/composer.json b/projects/packages/lazy-images/composer.json index dcda8cec925dc..58ed98381bfbd 100644 --- a/projects/packages/lazy-images/composer.json +++ b/projects/packages/lazy-images/composer.json @@ -64,5 +64,6 @@ "allow-plugins": { "roots/wordpress-core-installer": true } - } + }, + "abandoned": true }