diff --git a/projects/packages/constants/.phan/baseline.php b/projects/packages/constants/.phan/baseline.php index 52e0bc845738c..3df50068147ad 100644 --- a/projects/packages/constants/.phan/baseline.php +++ b/projects/packages/constants/.phan/baseline.php @@ -8,12 +8,9 @@ * (can be combined with --load-baseline) */ return [ - // # Issue statistics: - // PhanTypeMismatchArgumentProbablyReal : 3 occurrences - + // This baseline has no suppressions // Currently, file_suppressions and directory_suppressions are the only supported suppressions 'file_suppressions' => [ - 'tests/php/test-constants.php' => ['PhanTypeMismatchArgumentProbablyReal'], ], // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed. // (directory_suppressions will currently be ignored by subsequent calls to --save-baseline, but may be preserved in future Phan releases) diff --git a/projects/packages/constants/changelog/fix-phan-issues-in-constants-pkg b/projects/packages/constants/changelog/fix-phan-issues-in-constants-pkg new file mode 100644 index 0000000000000..d592e0686c904 --- /dev/null +++ b/projects/packages/constants/changelog/fix-phan-issues-in-constants-pkg @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Fix phpdoc type on `Constants::set_constant()` value parameter. diff --git a/projects/packages/constants/src/class-constants.php b/projects/packages/constants/src/class-constants.php index 3aca201c1b9f3..45768a941c66a 100644 --- a/projects/packages/constants/src/class-constants.php +++ b/projects/packages/constants/src/class-constants.php @@ -91,8 +91,8 @@ public static function get_constant( $name ) { /** * Sets the value of the "constant" within constants Manager. * - * @param string $name The name of the constant. - * @param scalar $value The value of the constant. + * @param string $name The name of the constant. + * @param int|float|string|bool|array|null $value The value of the constant. */ public static function set_constant( $name, $value ) { self::$set_constants[ $name ] = $value;