Remove scssc 0.0.12, replace with ScssPhp 1.1.11 via composer

[mreishus]

Proposed changes:

• Remove scssc 0.0.12, replace with ScssPhp 1.1.11
• ✔️ Is this the right composer file to edit?
• ✔️ Will this work on WPCOM? The autoloading works fine on my local jetpack docker, but I know traditionally WPCOM hasn't had a good autoloading setup.
  • It's working for me now, after 6442da7

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• You might have to turn this on in jetpack settings

• Use an older theme like twentytwentyone
• Go to customizer -> additional css
• Add this css

// Variables
$primary-bg-color: #f4f4f4;
$secondary-bg-color: #4CAF50;
$text-color: #333;

// Mixin for text styling
@mixin text-styling($size, $color: $text-color) {
  font-size: $size;
  color: $color;
}

// Global styles to check if SCSS is working
body {
  background-color: $primary-bg-color;
  @include text-styling(16px);
}

h1 {
  @include text-styling(36px, #ff0000);
}

// Nested Rules
.container {
  width: 100%;
  padding: 15px;
  background-color: $secondary-bg-color;
  @include text-styling(18px, white);

  .box {
    width: 50%;
    margin: 10px auto;
    padding: 10px;
    background-color: white;
    border: 1px solid $secondary-bg-color;

    h2 {
      @include text-styling(24px, $secondary-bg-color);
    }
  }
}

• Change preprocessor to SCSS
• Save
• The site should now have a gray background with large text
  

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/scss branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/scss
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for November 3, 2023 (scheduled code freeze on October 27, 2023).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[anomiex]

Is this the right composer file to edit?

Yes

Will this work on WPCOM?

I think this won't work anywhere yet, since the package files aren't flagged for being included in the plugin zip. You'll need to add an entry like these:

jetpack/projects/plugins/jetpack/.gitattributes

Lines 18 to 19 in fc6209a

	/vendor/nojimage/** production-include
	/vendor/wikimedia/aho-corasick/** production-include

Once that's done, wpcom should work too. We'll have to make sure to test that, of course, following the bot's instructions.

[mreishus]

Ok, nice, it is working on wpcom

[anomiex]

LGTM