Untangle: Enable user data fields & color scheme selector

[lupus2k]

Follow-up: #35235

Proposed changes:

Removes all wpcom related data from Profile and make the Admin Color Schema work when enable it by using this PR: https://github.com/Automattic/wpcomsh/pull/1669

Before	After

Jetpack product discussion

paYJgx-4uN-p2#comment-4524

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Apply this wpcomsh PR (follow the instructions): https://github.com/Automattic/wpcomsh/pull/1669
• Set your Admin interface style to Classic (wp-admin) in wordpress.com/hosting-config/site_slug
• Go to wp-admin
• Users > Profile should link to wp-admin profile page
• Color Scheme should show different Schemes, and you can switch them.
• Try reloading after changing the Scheme.
• User data (Name, About yourself) is editable.
• Try editing it, saving and reloading.
• Color and user data should not affect Calypso/wpcom.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/untangle-my-profile-to-profile-test branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/untangle-my-profile-to-profile-test
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for March 5, 2024 (scheduled code freeze on March 4, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Debug Helper plugin:

• Next scheduled release: March 5, 2024.
• Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Backup plugin:

• Next scheduled release: March 5, 2024.
• Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Boost plugin:

• Next scheduled release: March 5, 2024.
• Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Search plugin:

• Next scheduled release: March 5, 2024.
• Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Social plugin:

• Next scheduled release: March 5, 2024.
• Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Starter Plugin plugin:

• Next scheduled release: March 5, 2024.
• Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Protect plugin:

• Next scheduled release: March 5, 2024.
• Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Videopress plugin:

• Next scheduled release: March 5, 2024.
• Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Super Cache plugin:

• Next scheduled release: March 5, 2024.
• Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Migration plugin:

• Next scheduled release: March 5, 2024.
• Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Mu Wpcom plugin:

• Next scheduled release: March 5, 2024.
• Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Inspect plugin:

• Next scheduled release: March 5, 2024.
• Scheduled code freeze: February 26, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[fushar]

After exploring the codebase a bit more, I think the whole logic is self-contained in this file:

projects/plugins/jetpack/modules/masterbar/profile-edit/bootstrap.php

What if, we just don't include that file when the classic style is enabled? So the change is simply:

diff --git a/projects/plugins/jetpack/modules/masterbar.php b/projects/plugins/jetpack/modules/masterbar.php
index aacde02a96..e61fa14b49 100644
--- a/projects/plugins/jetpack/modules/masterbar.php
+++ b/projects/plugins/jetpack/modules/masterbar.php
@@ -28,7 +28,11 @@ new Admin_Color_Schemes();
 if ( ( new Host() )->is_woa_site() ) {
 	new Inline_Help();
 	require_once __DIR__ . '/masterbar/wp-posts-list/bootstrap.php';
-	require_once __DIR__ . '/masterbar/profile-edit/bootstrap.php';
+
+	if ( get_option( 'wpcom_admin_interface' ) !== 'wp-admin' ) {
+		require_once __DIR__ . '/masterbar/profile-edit/bootstrap.php';
+	}
+
 	require_once __DIR__ . '/masterbar/nudges/bootstrap.php';
 }

(Haven't tested it, though.)

[lupus2k]

After exploring the codebase a bit more, I think the whole logic is self-contained in this file:

projects/plugins/jetpack/modules/masterbar/profile-edit/bootstrap.php

Interesting, I'll take a look and test if everything works as expected. Thanks!

[lupus2k]

@fushar, I updated with your suggestion and it works great, thanks for that 🎉

[lupus2k]

Closed in favor of #36341