Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements: Implement users table user invite #35278

Open
4 tasks done
crisbusquets opened this issue Jan 26, 2024 · 4 comments
Open
4 tasks done

UI improvements: Implement users table user invite #35278

crisbusquets opened this issue Jan 26, 2024 · 4 comments
Assignees
Labels
[Feature] SSO [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@crisbusquets
Copy link
Contributor

crisbusquets commented Jan 26, 2024

Related to:

WP Admin

  • Add a title to the new column
  • Change the text style for Connected: that option isn't clickable, and it's confusing. It should have the same style as the role.

Image

  • When we show the option to Invite or inform that its Pending, the background should have a color that's different from red (which implies an error). A light yellow/orange would do the trick, as it's a warning (similar to the color we use in Calypso when the invite is pending).

Image

Calypso

  • The actions could be at the bottom. This way we could show the full email.

Image

@crisbusquets crisbusquets self-assigned this Jan 26, 2024
@escapemanuele
Copy link
Contributor

escapemanuele commented Jan 26, 2024

If with

A light yellow/orange would do the trick, as it's a warning (similar to the color we use in Calypso when the invite is pending).

We mean

image

Then the color should be var(--studio-yellow-50); #9d6e00;

@crisbusquets
Copy link
Contributor Author

crisbusquets commented Jan 29, 2024

Then the color should be var(--studio-yellow-50); #9d6e00;

If it's studio yellow, we can use var(--studio-yellow-5); #F5E6B3;

Screenshot 2024-01-29 at 11 19 06

I also tested with var(--studio-yellow-0); #F5F1E1; but it's too light:
Screenshot 2024-01-29 at 11 19 42

@crisbusquets
Copy link
Contributor Author

About Add a title to the new column, given that the options can be connected, invite, pending... I suggest using Status.

300047615-2f1aaf75-4901-488b-8b46-a969ebe81e62

WDYT @alshakero?

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] SSO [Pri] Normal [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jan 29, 2024
@escapemanuele
Copy link
Contributor

escapemanuele commented Jan 29, 2024

I'm working on the header and the colors now 👍 @Automattic/vertex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] SSO [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

3 participants