Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing Buttons: Add SMS sharing button #35426

Closed
Tracked by #35993
andrii-lysenko opened this issue Feb 2, 2024 · 3 comments
Closed
Tracked by #35993

Sharing Buttons: Add SMS sharing button #35426

andrii-lysenko opened this issue Feb 2, 2024 · 3 comments
Assignees
@andrii-lysenko
Labels
[Block] Sharing Button [Block] Sharing Buttons [Feature] Sharing Post sharing, sharing buttons [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@andrii-lysenko
Copy link
Contributor

andrii-lysenko commented Feb 2, 2024 •
edited
Loading

Context: pdHDFB-J-p2
@andrii-lysenko andrii-lysenko self-assigned this Feb 2, 2024
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Sharing Post sharing, sharing buttons labels Feb 5, 2024
@jeherve jeherve mentioned this issue Feb 7, 2024
Closed
5 tasks
@jeherve jeherve mentioned this issue Feb 27, 2024
Open
@andrii-lysenko
Copy link
Contributor Author

@keoshi @jeherve What do you think about this behavior?

Screen.Recording.2024-02-28.at.2.43.43.PM.mov

As per hiding the button for unsupported devices, we are actually might not be able to distinct this accurately. I remember someone mentioned that maybe, the way to go in such situations, is to have a separate block or feature (like a group that will be shown on one devices and hidden for others). What do you think?

@andrii-lysenko andrii-lysenko mentioned this issue Feb 28, 2024
Closed
3 tasks
@keoshi
Copy link
Contributor

keoshi commented Mar 4, 2024

That looks great to me and what I would expect to happen.

@andrii-lysenko
Copy link
Contributor Author

We decided to close this for now as we can't insure 100% quality of this feature.
More details: pf5801-GC-p2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrii-lysenko andrii-lysenko

Labels
[Block] Sharing Button [Block] Sharing Buttons [Feature] Sharing Post sharing, sharing buttons [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sharing Block: add SMS button Automattic/jetpack
3 participants
@keoshi @jeherve @andrii-lysenko