-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carousel conflict WP 6.5.2 Expand on click #36820
Comments
|
That's indeed the expected behavior. When Jetpack's Carousel currently offers more features than Core's Lightbox feature, we opted to automatically disable Core's feature when Jetpack's Carousel feature is enabled. This change was introduced in #36565. In the future, and when Core's Lightbox feature becomes closer to Jetpack's Carousel, we may opt to deprecate Jetpack's feature in favor of Core's. I hope this clarifies things. Let me know if you have more questions! |
@jeherve How is Jetpack Carousel a better option when it doesn't apply to the Image block? We are disabling a feature deliberately without offering a replacement. Can we let Jetpack Corusel take over the Gallery, but leave the image block unaffected? |
It does, unless you've deactivated that option via a filter, or if you do not add a link to the attachment page to the image: Screen.Recording.2024-10-20.at.19.38.48.movDo you think we should disable the existing Carousel behaviour for single images inserted via an image block, and show the core lightbox instead? |
Yes, because the core block interaction is better:
|
Wordpress: version 6.5.2
Jetpack: version 13.3
Theme: Twenty Twenty-Four - Version: 1.1
Multisite: subdirectory
Gutenberg: not insalled - Version 18.0.1
Google Chrome: Version 123.0.6312.107 (Official Build) (x86_64)
Jetpack Carousel module activation results in Wordpress
core/image
"Expand on Click" not being available.Jetpack deactivated
Jetpack activated
Jetpack activated
Console clean
image element html output
The text was updated successfully, but these errors were encountered: