Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel conflict WP 6.5.2 Expand on click #36820

Open
djcowan opened this issue Apr 10, 2024 · 5 comments
Open

Carousel conflict WP 6.5.2 Expand on click #36820

djcowan opened this issue Apr 10, 2024 · 5 comments
Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Bug When a feature is broken and / or not performing as intended

Comments

@djcowan
Copy link

djcowan commented Apr 10, 2024

Wordpress: version 6.5.2
Jetpack: version 13.3
Theme: Twenty Twenty-Four - Version: 1.1
Multisite: subdirectory
Gutenberg: not insalled - Version 18.0.1

Google Chrome: Version 123.0.6312.107 (Official Build) (x86_64)

Jetpack Carousel module activation results in Wordpress core/image "Expand on Click" not being available.

Jetpack deactivated

Screenshot 2024-04-10 at 9 24 14 pm

Jetpack activated

  • start free account
  • all Jetpack modules deactivated
    Screenshot 2024-04-10 at 9 36 08 pm

Jetpack activated

  • start free account
  • Jetpack Carousel module activated
    Screenshot 2024-04-10 at 9 40 47 pm
    Screenshot 2024-04-10 at 9 42 56 pm

Console clean

  • no errors
  • no network errors

image element html output

<div class="entry-content wp-block-post-content has-global-padding is-layout-constrained wp-block-post-content-is-layout-constrained">
<figure class="wp-block-image size-large"><img fetchpriority="high" decoding="async" width="1024" height="683" data-attachment-id="26" data-permalink="https://www.example.com/vanilla/sample-page/7080233_3528721/" data-orig-file="https://www.example.com/vanilla/wp-content/uploads/sites/6/2024/02/7080233_3528721-scaled.jpg" data-orig-size="2560,1707" data-comments-opened="1" data-image-meta="{&quot;aperture&quot;:&quot;0&quot;,&quot;credit&quot;:&quot;&quot;,&quot;camera&quot;:&quot;&quot;,&quot;caption&quot;:&quot;&quot;,&quot;created_timestamp&quot;:&quot;0&quot;,&quot;copyright&quot;:&quot;&quot;,&quot;focal_length&quot;:&quot;0&quot;,&quot;iso&quot;:&quot;0&quot;,&quot;shutter_speed&quot;:&quot;0&quot;,&quot;title&quot;:&quot;&quot;,&quot;orientation&quot;:&quot;0&quot;}" data-image-title="7080233_3528721" data-image-description="" data-image-caption="" data-medium-file="https://www.example.com/vanilla/wp-content/uploads/sites/6/2024/02/7080233_3528721-300x200.jpg" data-large-file="https://www.example.com/vanilla/wp-content/uploads/sites/6/2024/02/7080233_3528721-1024x683.jpg" src="https://www.example.com/vanilla/wp-content/uploads/sites/6/2024/02/7080233_3528721-1024x683.jpg" alt="" class="wp-image-26" srcset="https://www.example.com/vanilla/wp-content/uploads/sites/6/2024/02/7080233_3528721-1024x683.jpg 1024w, https://www.example.com/vanilla/wp-content/uploads/sites/6/2024/02/7080233_3528721-300x200.jpg 300w, https://www.example.com/vanilla/wp-content/uploads/sites/6/2024/02/7080233_3528721-768x512.jpg 768w, https://www.example.com/vanilla/wp-content/uploads/sites/6/2024/02/7080233_3528721-1536x1024.jpg 1536w, https://www.example.com/vanilla/wp-content/uploads/sites/6/2024/02/7080233_3528721-2048x1365.jpg 2048w" sizes="(max-width: 1024px) 100vw, 1024px" /></figure>
</div>
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] Normal [Closed] Won't Fix wontfix. This issue will not be addressed. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Apr 10, 2024
@djcowan
Copy link
Author

djcowan commented Apr 10, 2024

#32668 (comment)
@jeherve

  • Gutenberg issue reference: 55407

@jeherve
Copy link
Member

jeherve commented Apr 10, 2024

Jetpack Carousel module activation results in Wordpress core/image "Expand on Click" not being available.

That's indeed the expected behavior. When Jetpack's Carousel currently offers more features than Core's Lightbox feature, we opted to automatically disable Core's feature when Jetpack's Carousel feature is enabled. This change was introduced in #36565.

In the future, and when Core's Lightbox feature becomes closer to Jetpack's Carousel, we may opt to deprecate Jetpack's feature in favor of Core's.

I hope this clarifies things. Let me know if you have more questions!

@p3ob7o
Copy link
Member

p3ob7o commented Oct 19, 2024

@jeherve How is Jetpack Carousel a better option when it doesn't apply to the Image block? We are disabling a feature deliberately without offering a replacement.

Can we let Jetpack Corusel take over the Gallery, but leave the image block unaffected?

@p3ob7o p3ob7o reopened this Oct 19, 2024
@jeherve
Copy link
Member

jeherve commented Oct 20, 2024

How is Jetpack Carousel a better option when it doesn't apply to the Image block?

It does, unless you've deactivated that option via a filter, or if you do not add a link to the attachment page to the image:

Screen.Recording.2024-10-20.at.19.38.48.mov

Do you think we should disable the existing Carousel behaviour for single images inserted via an image block, and show the core lightbox instead?

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Closed] Won't Fix wontfix. This issue will not be addressed. labels Oct 20, 2024
@p3ob7o
Copy link
Member

p3ob7o commented Dec 20, 2024

Do you think we should disable the existing Carousel behaviour for single images inserted via an image block, and show the core lightbox instead?

Yes, because the core block interaction is better:

  • It's not obvious that one has to link to the attachment page (why not to the media file?).
  • The core image block expanded image doesn't require to aim for a tiny x in the top-right corner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests

3 participants