Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Search Block: Incorrect Heading sequence for filters in Footer Widget #38930

Open
alinclamba opened this issue Aug 16, 2024 · 2 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Search For all things related to Search Groundskeeping Worked on by Dotcom Groundskeeping [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Pri] Normal [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@alinclamba
Copy link

alinclamba commented Aug 16, 2024

Impacted plugin

Jetpack, Search

Quick summary

When the Jetpack Search block is added to the footer widget area, the filter headings are generated as H4 without a preceding H3, which can negatively impact SEO due to improper heading hierarchy.

Issue reported by a user here: 8599734-zd-a8c

Steps to reproduce

  1. Go to Appearance > Customize > Widgets > Footer.
  2. Add the Jetpack Search block to the Footer widget area.
  3. Enable filters (Tags, Categories) within the Jetpack Search block

FiJ0ax.png

A clear and concise description of what you expected to happen.

The filter headings should follow a sequential heading order, ideally starting with H3, or there should be an option to customize the heading level.

What actually happened

The filter headings are automatically generated as H4, despite no H3 heading preceding them, which may cause SEO issues.

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No direct workarounds within the block settings. A custom CSS workaround can be implemented, but it requires manual intervention and it doesn't solve the issue, as it can only eventually style the H4 to look like H3, but it's not what user really needs.

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@alinclamba alinclamba added [Type] Bug When a feature is broken and / or not performing as intended User Report Needs triage Ticket needs to be triaged labels Aug 16, 2024
@github-actions github-actions bot added [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Pri] High labels Aug 16, 2024
Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 8599734-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Aug 16, 2024
@bizanimesh bizanimesh added Triaged and removed Needs triage Ticket needs to be triaged labels Aug 16, 2024
@matticbot matticbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Aug 16, 2024
@agrullon95 agrullon95 self-assigned this Aug 23, 2024
@agrullon95 agrullon95 moved this from Triaged to In Progress in Automattic Prioritization: The One Board ™ Aug 23, 2024
@agrullon95 agrullon95 removed their assignment Aug 24, 2024
@DustyReagan DustyReagan self-assigned this Aug 27, 2024
@DustyReagan DustyReagan added the Groundskeeping Worked on by Dotcom Groundskeeping label Aug 27, 2024
@matticbot matticbot moved this from In Progress to Triaged in Automattic Prioritization: The One Board ™ Aug 27, 2024
@DustyReagan
Copy link
Member

I started to make this change from an H3 to an H4, but it occurred to me that this could be a "breaking change" to users who have custom CSS selected on this H4 tag. Thinking about this issue a little further, we could make this a user option, but that will require adding complexity to the UI. So, I started a discussion (p1724940143519689-slack-C029GN3KD) on the SEO benefits. It seems that the H4 tag could potentially be beneficial in giving more SEO "weight" to the content above it. So, even though an H3 tag might be more semantically correct, the SEO benefits of updating the tag are up for debate.

I believe this leaves the options of making this a user setting or leaving the tag as it is. For now, I've decreased this issue's priority to "normal."

@DustyReagan DustyReagan removed their assignment Aug 29, 2024
@DustyReagan DustyReagan added the [Feature] Search For all things related to Search label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Search For all things related to Search Groundskeeping Worked on by Dotcom Groundskeeping [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Pri] Normal [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests

5 participants