Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoPress: Update notice for disabled VideoPress module to show Enable instead of Connect #39066

Closed
oskosk opened this issue Aug 25, 2024 · 3 comments · Fixed by #39628
Closed

VideoPress: Update notice for disabled VideoPress module to show Enable instead of Connect #39066

oskosk opened this issue Aug 25, 2024 · 3 comments · Fixed by #39628
Assignees
@phcp
Labels
[Block] VideoPress [Closed] Duplicate Duplicate of an existing issue. Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] VideoPress A feature to help you upload and insert videos on your site. Groundskeeping Worked on by Dotcom Groundskeeping [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] TBD Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@oskosk
Copy link
Contributor

oskosk commented Aug 25, 2024

In the main Jetpack plugin, when the module is disabled, we shoow a prompt to enable the module, but the button reads Connect

image

Example showing an attempt to transform a VideoPress embed, to a VideoPress block

videopress-module-bug.mov
@oskosk oskosk added [Type] Bug When a feature is broken and / or not performing as intended [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Block] VideoPress labels Aug 25, 2024
@oskosk oskosk changed the title VideoPress: Update notice for disabled Videopress module to show Enable instead of Connect VideoPress: Update notice for disabled VideoPress module to show Enable instead of Connect Aug 25, 2024
@jeherve jeherve added the [Feature] VideoPress A feature to help you upload and insert videos on your site. label Aug 26, 2024
@phcp phcp self-assigned this Oct 2, 2024
@phcp phcp moved this from Needs Triage to In Triage in Automattic Prioritization: The One Board ™ Oct 2, 2024
@phcp phcp mentioned this issue Oct 2, 2024
Closed
3 tasks
@phcp phcp linked a pull request Oct 2, 2024 that will close this issue
Update VideoPress block connection banner, align with other blocks #39628
Merged
3 tasks
@phcp
Copy link
Contributor

phcp commented Oct 2, 2024 •
edited
Loading

I was working on a quick fix for this, but I noticed that this issue is being addressed by this PR. I'll close this as duplicate since the original issue related to this PR already covers it.

@phcp phcp added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Triaged Groundskeeping Worked on by Dotcom Groundskeeping labels Oct 2, 2024
@phcp phcp moved this from In Triage to Needs Review in Automattic Prioritization: The One Board ™ Oct 2, 2024
@matticbot matticbot moved this from Needs Review to Triaged in Automattic Prioritization: The One Board ™ Oct 2, 2024
@phcp phcp closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2024
@phcp phcp added [Closed] Duplicate Duplicate of an existing issue. and removed [Status] In Progress [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 2, 2024
@CodeyGuyDylan
Copy link
Contributor

@phcp FYI I also wrote about some ways the connection/activation flow could be improved here (pbNhbs-bHl-p2#comment-23858) 😄

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • pbNhbs-bHl-p2#comment-23858

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phcp phcp

Labels
[Block] VideoPress [Closed] Duplicate Duplicate of an existing issue. Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] VideoPress A feature to help you upload and insert videos on your site. Groundskeeping Worked on by Dotcom Groundskeeping [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] TBD Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Automattic Prioritization: The One Board ™
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update VideoPress block connection banner, align with other blocks Automattic/jetpack
4 participants
@jeherve @oskosk @phcp @CodeyGuyDylan