Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity Log: Uploading Plugin is Logged as an Attachment #39608

Open
bobmatyas opened this issue Oct 1, 2024 · 2 comments
Open

Activity Log: Uploading Plugin is Logged as an Attachment #39608

bobmatyas opened this issue Oct 1, 2024 · 2 comments
Assignees
Labels
[Feature] Activity Log Groundskeeping Worked on by Dotcom Groundskeeping [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Type] Bug When a feature is broken and / or not performing as intended [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@bobmatyas
Copy link
Contributor

Impacted plugin

Jetpack

Quick summary

When uploading a plugin via WP Admin, the Activity Log references it as uploading an attachment and then shows it as a deleted attachment after installation.

This could probably be consolidated into one log entry, perhaps "Plugin manually uploaded and installed"

Steps to reproduce

  1. Upload a plugin
  2. View the Activity Log and notice references to attacments

A clear and concise description of what you expected to happen.

I would expect the Activity Log to be more clear about what happens when manually uploading a plugin

What actually happened

d3dbd9ffee57a209c2cb417731c3dff750e6117317c7d9a0497aca4e49220d4b8f8c36ae7ebd70d692588cc0ff3597b94226115c64494818c3e447a52d682b49

Impact

Most (> 50%)

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@bobmatyas bobmatyas added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Activity Log Needs triage Ticket needs to be triaged labels Oct 1, 2024
@github-actions github-actions bot added [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Oct 1, 2024
@vykes-mac vykes-mac self-assigned this Oct 1, 2024
@vykes-mac vykes-mac added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Oct 1, 2024
@vykes-mac
Copy link
Contributor

Image

I played around with this to see the effort required. I changed Attachment uploaded to Plugin uploaded. I'm wondering if this enhancement is worth the effort though. Technically uploading the plugin zip file is an attachment. We would need to determine if the activity log for that attachment is a plugin then return the appropriate messaging. We may do the check when the log is being returned which would require less effort than changing the log when it's been written, that would have further consequences as we would probably need to backfill older logs.

@vykes-mac vykes-mac added the Groundskeeping Worked on by Dotcom Groundskeeping label Oct 2, 2024
@supernovia supernovia removed the Needs triage Ticket needs to be triaged label Oct 2, 2024
@supernovia supernovia moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 2, 2024
@supernovia
Copy link

📌 ACTIONS

  • Already triaged by devs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Activity Log Groundskeeping Worked on by Dotcom Groundskeeping [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Type] Bug When a feature is broken and / or not performing as intended [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
Development

No branches or pull requests

4 participants