Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story Block Roloads The Page Instead Of Opening In Full Screen #39829

Closed
mxhassani opened this issue Oct 19, 2024 · 2 comments · Fixed by #39870
Closed

Story Block Roloads The Page Instead Of Opening In Full Screen #39829

mxhassani opened this issue Oct 19, 2024 · 2 comments · Fixed by #39870
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Misc Blocks Other Jetpack blocks. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Needs triage Ticket needs to be triaged [Platform] Atomic [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended

Comments

@mxhassani
Copy link

mxhassani commented Oct 19, 2024

Impacted plugin

Jetpack

Quick summary

When clicking the story block on the front end, it reloads the page and adds a ?wp-story-load-in-fullscreen=true&wp-story-play-on-load=true to the URL then doesn't play.

Spoiler warning
<!-- wp:jetpack/story {"mediaFiles":[{"alt":"","title":"wp_story1607626718265_0","id":183439,"link":"https://en.support.wordpress.com/wp_story1607626718265_0/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1607626718265_0.jpg?w=576"},{"alt":"","title":"wp_story1606945178567_1","id":183438,"link":"https://en.support.wordpress.com/wp_story1606945178567_1/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1606945178567_1.jpg?w=576"},{"alt":"","title":"wp_story1606945178643_2","id":183437,"link":"https://en.support.wordpress.com/wp_story1606945178643_2/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1606945178643_2.jpg?w=576"},{"alt":"","title":"wp_story1606945178713_3","id":183436,"link":"https://en.support.wordpress.com/wp_story1606945178713_3/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1606945178713_3.jpg?w=576"},{"alt":"","title":"wp_story1607626718407_3","id":183435,"link":"https://en.support.wordpress.com/wp_story1607626718407_3/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1607626718407_3.jpg?w=576"},{"alt":"","title":"wp_story1606944816461_7","id":183434,"link":"https://en.support.wordpress.com/wp_story1606944816461_7/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1606944816461_7.jpg?w=576"},{"alt":"","title":"wp_story1606945178946_6","id":183433,"link":"https://en.support.wordpress.com/wp_story1606945178946_6/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1606945178946_6.jpg?w=576"},{"alt":"","title":"wp_story1607626718812_2","id":183440,"link":"https://en.support.wordpress.com/wp_story1607626718812_2/","type":"video","mime":"video/mp4","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1607626718812_2.mp4"}]} -->
<div class="wp-story wp-block-jetpack-story"></div>
<!-- /wp:jetpack/story -->

Steps to reproduce

  1. On an Atomic site
  2. Create a story block and upload content to it. Or You can use the following code to add a copy of the block showcased in our support document:
Use cmd+shift+v
<!-- wp:jetpack/story {"mediaFiles":[{"alt":"","title":"wp_story1607626718265_0","id":183439,"link":"https://en.support.wordpress.com/wp_story1607626718265_0/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1607626718265_0.jpg?w=576"},{"alt":"","title":"wp_story1606945178567_1","id":183438,"link":"https://en.support.wordpress.com/wp_story1606945178567_1/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1606945178567_1.jpg?w=576"},{"alt":"","title":"wp_story1606945178643_2","id":183437,"link":"https://en.support.wordpress.com/wp_story1606945178643_2/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1606945178643_2.jpg?w=576"},{"alt":"","title":"wp_story1606945178713_3","id":183436,"link":"https://en.support.wordpress.com/wp_story1606945178713_3/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1606945178713_3.jpg?w=576"},{"alt":"","title":"wp_story1607626718407_3","id":183435,"link":"https://en.support.wordpress.com/wp_story1607626718407_3/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1607626718407_3.jpg?w=576"},{"alt":"","title":"wp_story1606944816461_7","id":183434,"link":"https://en.support.wordpress.com/wp_story1606944816461_7/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1606944816461_7.jpg?w=576"},{"alt":"","title":"wp_story1606945178946_6","id":183433,"link":"https://en.support.wordpress.com/wp_story1606945178946_6/","type":"image","mime":"image/jpeg","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1606945178946_6.jpg?w=576"},{"alt":"","title":"wp_story1607626718812_2","id":183440,"link":"https://en.support.wordpress.com/wp_story1607626718812_2/","type":"video","mime":"video/mp4","caption":"","width":1080,"height":1920,"url":"https://en.support.files.wordpress.com/2021/06/wp_story1607626718812_2.mp4"}]} -->
<div class="wp-story wp-block-jetpack-story"></div>
<!-- /wp:jetpack/story -->
  1. Save and view on front end.
  2. Click the Block.

A clear and concise description of what you expected to happen.

I expected to see a full width carousel: Image

What actually happened

The page is reloaded and ?wp-story-load-in-fullscreen=true&wp-story-play-on-load=true is added to the URL.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

Workaround:
User another video block.

Platform (Simple and/or Atomic)

Atomic

Logs or notes

It works fine on Simple sites.
Independent from theme Classic or FSE.
8898861-zen

@mxhassani mxhassani added [Feature] Misc Blocks Other Jetpack blocks. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Oct 19, 2024
Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 8898861-zen

@github-actions github-actions bot added [Pri] Low Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" labels Oct 19, 2024
@anomiex
Copy link
Contributor

anomiex commented Oct 22, 2024

Appears to have been caused by #39604, see #39604 (comment) for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Misc Blocks Other Jetpack blocks. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Needs triage Ticket needs to be triaged [Platform] Atomic [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended
Development

Successfully merging a pull request may close this issue.

3 participants