Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel: Accessibility - when image set to 'Attachment page', clicking and tabbing should result in same behavior #39926

Open
Tracked by #35726
coder-karen opened this issue Oct 28, 2024 · 0 comments
Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Focus] Accessibility Improving usability for all users (a11y) [Pri] Normal

Comments

@coder-karen
Copy link
Contributor

Issue

An image set to link to an attachment page opens a lightbox if Carousel is enabled, if using a keyboard and pressing enter. However if the image is clicked on with a mouse, it opens the attachment page (it seems there should be consistency here). If Carousel is not enabled, both clicking on it and tabbing to it then clicking / entering open the attachment page (this appears to be expected).

How to reproduce

This was tested on self-hosted and WoA.

  1. On a test site, ensure the full-screen Carousel option is enabled under Jetpack > Settings > Writing: /wp-admin/admin.php?page=jetpack#/writing
  2. Create a new post and add an image block.
  3. Ensure 'Link to attachment page' is set for the 'Link' option:

Image

  1. Save and preview
  2. Click on the image - the attachment page will open
  3. Then, tab onto the image and press enter. A lightbox will open instead.

What should happen

I'd expect when clicking on the image with Carousel enabled, that a lightbox would open (or at the least, that the behavior between clicking and tabbing would be the same).

Related conversations

#39913 (review)

@coder-karen coder-karen added [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Focus] Accessibility Improving usability for all users (a11y) labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Focus] Accessibility Improving usability for all users (a11y) [Pri] Normal
Projects
None yet
Development

No branches or pull requests

2 participants