From fa33cd37022a6ab5f0d3f89dfce57acb4814e217 Mon Sep 17 00:00:00 2001 From: Ian Ramos <5714212+IanRamosC@users.noreply.github.com> Date: Wed, 17 Jul 2024 17:59:05 -0300 Subject: [PATCH 1/3] Search: Fix jetpack_search_customberg_save_button_click event properties --- .../customberg/components/save-button/index.jsx | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/projects/packages/search/src/customberg/components/save-button/index.jsx b/projects/packages/search/src/customberg/components/save-button/index.jsx index f7738338f2d1b..97f42027077ce 100644 --- a/projects/packages/search/src/customberg/components/save-button/index.jsx +++ b/projects/packages/search/src/customberg/components/save-button/index.jsx @@ -1,7 +1,6 @@ import { Button } from '@wordpress/components'; import { __ } from '@wordpress/i18n'; import useEntityRecordState from 'hooks/use-entity-record-state'; -import { SERVER_OBJECT_NAME } from 'instant-search/lib/constants'; import { eventPrefix, recordEvent } from 'lib/analytics'; import './styles.scss'; @@ -11,22 +10,13 @@ import './styles.scss'; * @returns {Element} component instance */ export default function SaveButton() { - const { - editedEntities: editedSettings, - isSaving, - hasUnsavedEdits, - saveRecords, - } = useEntityRecordState(); + const { isSaving, hasUnsavedEdits, saveRecords } = useEntityRecordState(); const onClick = ( ...args ) => { if ( isSaving ) { return; } - recordEvent( `${ eventPrefix }_save_button_click`, { - initialSettings: JSON.stringify( window[ SERVER_OBJECT_NAME ].overlayOptions ), - changedSettings: JSON.stringify( editedSettings ), - changedSettingNames: Object.keys( editedSettings ).join( ',' ), - } ); + recordEvent( `${ eventPrefix }_save_button_click` ); saveRecords( ...args ); }; From 1c019ca928d4133b311d0b2cf0acb150c9d57a86 Mon Sep 17 00:00:00 2001 From: Ian Ramos <5714212+IanRamosC@users.noreply.github.com> Date: Wed, 17 Jul 2024 18:00:17 -0300 Subject: [PATCH 2/3] changelog --- .../search/changelog/fix-jetpack_search_customberg-events | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 projects/packages/search/changelog/fix-jetpack_search_customberg-events diff --git a/projects/packages/search/changelog/fix-jetpack_search_customberg-events b/projects/packages/search/changelog/fix-jetpack_search_customberg-events new file mode 100644 index 0000000000000..c5267a874fa5a --- /dev/null +++ b/projects/packages/search/changelog/fix-jetpack_search_customberg-events @@ -0,0 +1,5 @@ +Significance: patch +Type: fixed +Comment: This commit fixes the property of a Tracks event that was being sent as a JSON, which is not a valid Tracks value. + + From 71585b9d4153c5c1ca9834febbd46455ee8ddb71 Mon Sep 17 00:00:00 2001 From: Ian Ramos <5714212+IanRamosC@users.noreply.github.com> Date: Wed, 17 Jul 2024 18:07:18 -0300 Subject: [PATCH 3/3] Fix project version --- projects/packages/search/package.json | 2 +- projects/packages/search/src/class-package.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/packages/search/package.json b/projects/packages/search/package.json index ae664f62b2c7c..e8089450aad85 100644 --- a/projects/packages/search/package.json +++ b/projects/packages/search/package.json @@ -1,6 +1,6 @@ { "name": "jetpack-search", - "version": "0.44.12", + "version": "0.44.13-alpha", "description": "Package for Jetpack Search products", "main": "main.js", "directories": { diff --git a/projects/packages/search/src/class-package.php b/projects/packages/search/src/class-package.php index 23f1e7b800a88..abb41f7635aac 100644 --- a/projects/packages/search/src/class-package.php +++ b/projects/packages/search/src/class-package.php @@ -11,7 +11,7 @@ * Search package general information */ class Package { - const VERSION = '0.44.12'; + const VERSION = '0.44.13-alpha'; const SLUG = 'search'; /**