Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker, actions: Update for Ubuntu 24.04 #39548

Merged
merged 1 commit into from
Sep 26, 2024
Merged

docker, actions: Update for Ubuntu 24.04 #39548

merged 1 commit into from
Sep 26, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Sep 26, 2024 •
edited
Loading

Proposed changes:

GitHub is preparing to roll out Ubuntu 24.04 to Actions. This prepares us for that.

  • Update our own Docker development environment to be based on 24.04.
  • svn has been removed from the default Actions image. Install it manually where needed.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • CI happy?
  • Temporarily change

    jetpack/tools/docker/docker-compose.yml

    Line 37 in 3fc6506

    image: automattic/jetpack-wordpress-dev:latest
    to refer to ghcr.io/automattic/jetpack-wordpress-dev:pr-39548 and restart your docker env (jetpack docker stop && jetpack docker up -d). Then make sure everything still works.

@anomiex
docker, actions: Update for Ubuntu 24.04
3fc6506 
GitHub is preparing to roll out Ubuntu 24.04 to Actions. This prepares
us for that.

* Update our own Docker development environment to be based on 24.04.
* `svn` has been removed from the default Actions image. Install it
  manually where needed.
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Sep 26, 2024
@anomiex anomiex requested a review from a team September 26, 2024 14:21
@anomiex anomiex self-assigned this Sep 26, 2024
@github-actions github-actions bot added Actions GitHub actions used to automate some of the work around releases and repository management Docker labels Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@kraftbj kraftbj self-requested a review September 26, 2024 15:35
kraftbj
kraftbj approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me on Apple silicon.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 26, 2024
@anomiex anomiex merged commit cc8772d into trunk Sep 26, 2024
59 checks passed
@anomiex anomiex deleted the update/for-ubuntu-24.04 branch September 26, 2024 16:40
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 26, 2024
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
@anomiex @gogdzl
docker, actions: Update for Ubuntu 24.04 (#39548)
b54ce02 
GitHub is preparing to roll out Ubuntu 24.04 to Actions. This prepares
us for that.

* Update our own Docker development environment to be based on 24.04.
* `svn` has been removed from the default Actions image. Install it
  manually where needed.
@zinigor zinigor mentioned this pull request Nov 27, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@anomiex anomiex

Labels
Actions GitHub actions used to automate some of the work around releases and repository management Docker [Pri] Normal [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anomiex @kraftbj