Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote with Blaze: Purge cache on Atomic sites when site visibility changes #40650

Merged
merged 8 commits into from
Dec 19, 2024
Merged

Promote with Blaze: Purge cache on Atomic sites when site visibility changes #40650

merged 8 commits into from
Dec 19, 2024

Conversation

BogdanUngureanu
Copy link
Contributor

@BogdanUngureanu BogdanUngureanu commented Dec 17, 2024 •
edited
Loading

This PR adds an improvement for Atomic sites that clears the eligibility cache every time the user changes the site's visibility status.

This is needed because currently the cache is set to 24h, meaning that the user will not be aware of the feature until the cache is expired and the eligibility call is triggered again.

Also, on Atomic sites, we no longer had the "Promote with Blaze" option, as we do for Simple Sites. This PR changes this to be more in line with the behavior we have on Simple and re-adds the item only for Atomic sites.

Related to Automattic/wp-calypso#95621

Proposed changes:

  • Purge the transient on Atomic sites when the site visibility changes
  • Bring back the quick link in posts list on Atomic sites

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Use the Jetpack beta and update wpcomsh and Jetpack
  • Go to an Atomic site and make it private (WP-Admin > Settings > General)
  • Notice that there's no menu item for WP-Admin > Tools > Advertising
  • Notice that in WP-Admin > Posts there's no "Promote with Blaze" quick link
  • Set the site to coming soon and repeat the steps
  • Set the site to public - you should now get the Tools >Advertising menu and the Posts > Promote with Blaze quick link
  • Set the visibility back and forth to make sure that the cache is indeed cleared properly.

@BogdanUngureanu BogdanUngureanu changed the title Promote with Blaze: Purge cache on Atomic sites when site visibility … Promote with Blaze: Purge cache on Atomic sites when site visibility changes Dec 17, 2024
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Wpcomsh labels Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for January 7, 2025 (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 17, 2024
@BogdanUngureanu BogdanUngureanu added [Status] Needs Team Review [Type] Bug When a feature is broken and / or not performing as intended and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Dec 17, 2024
@BogdanUngureanu BogdanUngureanu requested a review from a team December 17, 2024 17:40
@BogdanUngureanu BogdanUngureanu self-assigned this Dec 17, 2024
mmtr
mmtr reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@mmtr mmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well! Just left a minor comment suggesting to place the fix in jetpack-mu-wpcom.

projects/plugins/jetpack/modules/blaze.php Outdated Show resolved Hide resolved
@mmtr
Copy link
Member

mmtr commented Dec 18, 2024

Looks like this is causing some tests to fail with this error:

Error: Object of class WP_Error could not be converted to string
/tmp/wordpress-latest/src/wp-content/mu-plugins/wpcomsh/feature-plugins/blaze.php:77
/tmp/wordpress-latest/src/wp-content/mu-plugins/wpcomsh/feature-plugins/blaze.php:98

@BogdanUngureanu BogdanUngureanu requested review from mmtr and a team December 18, 2024 15:23
mmtr
mmtr previously approved these changes Dec 18, 2024
View reviewed changes
@BogdanUngureanu BogdanUngureanu merged commit 354fbd4 into trunk Dec 19, 2024
56 checks passed
@BogdanUngureanu BogdanUngureanu deleted the fix/atomic-promote-with-blaze branch December 19, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmtr mmtr mmtr left review comments

Assignees

@BogdanUngureanu BogdanUngureanu

Labels
[Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Wpcomsh [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BogdanUngureanu @mmtr