Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI Assistant: Add thumbs feedback on AI Assistant #40728

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

AI Assistant: Add thumbs feedback on AI Assistant #40728

wants to merge 3 commits into from
+70 −16

Conversation

dhasilva
Copy link
Contributor

Fixes #40574

Proposed changes:

  • Adds the thumbs feedback to the Message component
  • Displays it when appropriate

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to the block editor with the thumbs feedback feature enabled
  • Use the AI Assistant to generate some text
  • Check that you can rate it
  • On an extended block, ask for some change
  • Check that you can rate it
  • Test the written change or a toolbar action

Known issues: The toolbar actions are correctly mapped for extensions, but not for the AI Assistant block. Some plumbing and/or refactoring is necessary to get the human readable toolbar action in the block. Let's leave it for a follow-up.

Screenshot from 2024-12-23 20-14-39

@dhasilva dhasilva added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review labels Dec 23, 2024
@dhasilva dhasilva requested a review from a team December 23, 2024 23:35
@dhasilva dhasilva self-assigned this Dec 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/jetpack-ai-thumbs-feedback-ai-assistant branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/jetpack-ai-thumbs-feedback-ai-assistant

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions GitHub Actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

CGastrell
CGastrell reviewed Dec 24, 2024
View reviewed changes
projects/js-packages/ai-client/src/components/message/index.tsx
showSidebarIcon = false,
onSidebarIconClick = () => {},
showAIFeedbackThumbs = false,
ratedItem = '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GuidelineMessage passes down ratedItem which, in turn, is passed down to AiFeedbackThumbs but, so far, it always matches the feature prop (ai-assistant). Could ratedItem hold a value different to feature? I'm merely curious since looking at the code it seems like a duped prop value.

@CGastrell
Copy link
Contributor

This might not be directly related to this PR, but the footer message link behavior seems odd when there's not enough space:
image
image
Can't be sure if this is by design

@CGastrell CGastrell self-requested a review December 24, 2024 14:42
CGastrell
CGastrell approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole thing works and I agree we should follow up.

The only observations would be:

  • I'd like us to add more tracking props to understand usage/failure. These might include blockType or AI feature/option we're using. Right now we fill prompt with the action, and that is enough
  • With the above in mind, forms use the placeholder of the AI input to guide the user on next steps, so the rating event sent carries those guides as prompt (only case where it doesn't make sense)

Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGastrell CGastrell CGastrell approved these changes

Assignees

@dhasilva dhasilva

Labels
[JS Package] AI Client RNA [Status] Needs Team Review [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jetpack AI: Add thumbs up/down component to AI Assistant
2 participants
@dhasilva @CGastrell