diff --git a/mp4compose/src/main/java/com/daasuu/mp4compose/composer/Mp4ComposerBasic.java b/mp4compose/src/main/java/com/daasuu/mp4compose/composer/Mp4ComposerBasic.java index f138cf1f..1e207210 100644 --- a/mp4compose/src/main/java/com/daasuu/mp4compose/composer/Mp4ComposerBasic.java +++ b/mp4compose/src/main/java/com/daasuu/mp4compose/composer/Mp4ComposerBasic.java @@ -44,6 +44,9 @@ public class Mp4ComposerBasic implements ComposerInterface { private Listener listener; private FillMode fillMode = FillMode.PRESERVE_ASPECT_FIT; private FillModeCustomItem fillModeCustomItem; + // TODO: currently we do not use the timeScale feature. Also the timeScale ends up + // being converted into an int in the VideoComposer layer. + // See https://github.com/Automattic/stories-android/issues/685 for more context. private float timeScale = 1f; // should be in range 0.125 (-8X) to 8.0 (8X) private boolean isPitchChanged = false; private boolean flipVertical = false; diff --git a/mp4compose/src/main/java/com/daasuu/mp4compose/composer/Mp4ComposerEngineBasic.java b/mp4compose/src/main/java/com/daasuu/mp4compose/composer/Mp4ComposerEngineBasic.java index 16a7dbfb..9a755a25 100644 --- a/mp4compose/src/main/java/com/daasuu/mp4compose/composer/Mp4ComposerEngineBasic.java +++ b/mp4compose/src/main/java/com/daasuu/mp4compose/composer/Mp4ComposerEngineBasic.java @@ -54,6 +54,9 @@ void setProgressCallback(ProgressCallback progressCallback) { this.progressCallback = progressCallback; } + // TODO: currently we do not use the timeScale feature. Also the timeScale ends up + // being converted into an int in the VideoComposer layer. + // See https://github.com/Automattic/stories-android/issues/685 for more context. void compose( final DataSource srcDataSource, final String destSrc, diff --git a/mp4compose/src/main/java/com/daasuu/mp4compose/composer/VideoComposer.kt b/mp4compose/src/main/java/com/daasuu/mp4compose/composer/VideoComposer.kt index e6dda635..5459b4cb 100755 --- a/mp4compose/src/main/java/com/daasuu/mp4compose/composer/VideoComposer.kt +++ b/mp4compose/src/main/java/com/daasuu/mp4compose/composer/VideoComposer.kt @@ -36,6 +36,9 @@ internal class VideoComposer { private var encoderStarted: Boolean = false var writtenPresentationTimeUs: Long = 0 private set + // TODO: currently we do not use the timeScale feature. Also the timeScale ends up + // being converted into an int in here being a float in upper layers. + // See https://github.com/Automattic/stories-android/issues/685 for more context. private val timeScale: Int private var useStaticBkg: Boolean = false private var addedFrameCount = 0