Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the actual Gutenberg Story block on WPAndroid #504

Closed
mzorz opened this issue Aug 19, 2020 · 3 comments
Closed

Implement the actual Gutenberg Story block on WPAndroid #504

mzorz opened this issue Aug 19, 2020 · 3 comments
Assignees
Milestone

Comments

@mzorz
Copy link
Contributor

mzorz commented Aug 19, 2020

Currently, we're producing the Gutenberg block structure by hardcoding tags and using Gson serialization. We'll want to actually use mobile gutenberg to:

  • integrate the editor flows (show the block's placeholder, implement navigation to the Story editor) edit see Editing from local serialized Story #445
  • be able to correctly validate and save block information at creation time. This we might mark as optional?, we'll dig into this when the time comes - I'm thinking we probably can still leave this part as is, given in WPAndroid we're already using matchers in the BlockProcessor structure for dealing with block updates with media information coming from the server.
@mzorz
Copy link
Contributor Author

mzorz commented Aug 19, 2020

Some notes
wordpress-mobile/gutenberg-mobile#854 (comment)

To do this on Mobile, we might have to import the JetPack block, right?

I think we just need to read the VideoPress hash, query the native side (there is an API call that from a VP hash does return video info) and replace it with the video URL when the call returns.

Related Automattic/jetpack#12358

@mzorz
Copy link
Contributor Author

mzorz commented Oct 23, 2020

Feature branch PR being worked on here wordpress-mobile/WordPress-Android#13130

@mzorz
Copy link
Contributor Author

mzorz commented Nov 11, 2020

This is completed 🎉

@mzorz mzorz closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants