Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button updates #551

Closed
megsfulton opened this issue Sep 28, 2020 · 3 comments · Fixed by #563
Closed

Button updates #551

megsfulton opened this issue Sep 28, 2020 · 3 comments · Fixed by #563
Assignees
Labels
[Type] Enhancement An improvement to existing functionality.

Comments

@megsfulton
Copy link

megsfulton commented Sep 28, 2020

Update the styling of the X, Publish, and Done buttons.

These updates address the feedback we heard in Alpha 2 testing about the "done" button not being obvious. They also bring Android closer to the Kanvas UI.

What's changing:

  1. Adding a black transparent circle behind the X icon (same as the other icon buttons on the editing screen)
  2. Changing the "Next" button to a white circle with the Material arrow icon.
  3. Replace the "done" text button with a white circle button with the Material check icon.

Screen Shot 2020-09-28 at 2 02 57 PM

@aforcier aforcier self-assigned this Oct 3, 2020
@aforcier
Copy link
Collaborator

aforcier commented Oct 7, 2020

@megsfulton what should the button be in the case where we're editing a story from Gutenberg (#445)? It's currently 'Done', should we use the same checkmark button as in the text editing view? Or perhaps a back arrow?

@megsfulton
Copy link
Author

Let's use the checkmark there.

@aforcier aforcier linked a pull request Oct 10, 2020 that will close this issue
@aforcier aforcier added the [Type] Enhancement An improvement to existing functionality. label Oct 10, 2020
@aforcier
Copy link
Collaborator

Addressed in #563.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement An improvement to existing functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants