Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon to close the Settings modal has a very small click point. #507

Open
markbiek opened this issue Sep 3, 2024 · 7 comments
Open

Icon to close the Settings modal has a very small click point. #507

markbiek opened this issue Sep 3, 2024 · 7 comments
Labels
[Pri] Low [Type] Bug Something isn't working

Comments

@markbiek
Copy link

markbiek commented Sep 3, 2024

Quick summary

The icon to close the Settings modal has a very small click point that's mostly below the actual icon.

CleanShot 2024-09-03 at 13 58 46@2x

Steps to reproduce

  1. Open Studio.
  2. Go to Studio -> Settings
  3. Hover the mouse over the close icon. You'll notice that most of the icon isn't actually clickable. The click point is mostly below the icon.

What you expected to happen

I expected to be able to click anywhere on the X to close the settings.

What actually happened

Large portions of the icon aren't clickable.

CleanShot.2024-09-03.at.13.53.16.mp4

Impact

One

Available workarounds?

No but the app is still usable

Platform

Mac Silicon

Logs or notes

OSX Sonoma 14.5

Studio Version 1.1.1-dev.2287249

@danielbachhuber
Copy link
Contributor

Thanks for the report, @markbiek !

Feel free to submit a pull request if you'd like 😊

@renancarvalho
Copy link

I was unable to reproduce this issue, I checked using studio version 1.1.0 and the close button on the setting's modal was with the right clickable area, I checked its width and height and seems correct.

@retnonindya retnonindya removed the Needs triage Ticket needs to be triaged label Sep 5, 2024
@retnonindya retnonindya moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Sep 5, 2024
@markbiek
Copy link
Author

markbiek commented Sep 5, 2024

I was unable to reproduce this issue, I checked using studio version 1.1.0 and the close button on the setting's modal was with the right clickable area, I checked its width and height and seems correct.

I was using 1.1.1-dev.2287249. Is it possible this is a new issue?

@markbiek
Copy link
Author

markbiek commented Sep 5, 2024

I just upgraded to 1.1.1-dev.944bd21 and I'm still seeing the same behavior.

@wojtekn
Copy link
Contributor

wojtekn commented Sep 10, 2024

@markbiek I couldn't reproduce it using 1.1.1-dev.944bd21. The whole area shown when I focus button is clickable:

Screenshot 2024-09-10 at 11 39 10

Would you mind trying to focus the button using keyboard navigation to see what area it focuses on and share a screenshot showing the whole app window?

@inaikem
Copy link

inaikem commented Nov 12, 2024

Group Triage: Greetings @wojtekn, I'd like to work on a process for Studio issues that bypasses PA triage since the team appears to do a very good job of raising and working on them directly. Do you have any suggestions for streamlining?

@wojtekn
Copy link
Contributor

wojtekn commented Nov 12, 2024

Do you have any suggestions for streamlining?

Should we simply exclude studio issues from triage process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Low [Type] Bug Something isn't working
Projects
Development

No branches or pull requests

6 participants