Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: Slideshow block doesn't work in post template #8452

Closed
supernovia opened this issue Nov 24, 2024 · 5 comments · Fixed by #8463
Closed

Common: Slideshow block doesn't work in post template #8452

supernovia opened this issue Nov 24, 2024 · 5 comments · Fixed by #8463
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. Needs triage [Platform] Simple [Pri] Normal [Status] Auto-allocated [Theme] Common [Type] Bug Something isn't working

Comments

@supernovia
Copy link

Quick summary

The Jetpack Slideshow block doesn't play correctly in posts when Common with default templates is active. Buttons don't seem to respond, and some or all of the images seem to be off-page.

Steps to reproduce

  1. On a site with another theme active, create a post with a Jetpack slideshow. I used images with different aspect ratios, but this may not matter
  2. Note the slideshow works in the editor an on the site
  3. Switch to the Common theme
  4. Note the slideshow stops working on the site
  5. If I edit the template to remove the content block from the columns, the slideshow appears appropriately

A clear and concise description of what you expected to happen.

The slideshow should just work within its content box

What actually happened

The slideshow seems to fall out of the content area and either not display at all, or not respond as expected.

Impact

Some (< 50%)

Available workarounds?

Yes, difficult to implement

If the above answer is "Yes...", outline the workaround.

One can edit the single post template to move the content area so its outside the column layouts, but then it looks different than the theme is intended.

Platform (Simple and/or Atomic)

Simple

Logs or notes

Tested on simple but I'm sure this happens on Atomic, too.

@supernovia
Copy link
Author

Case here:
9083028-zd-a8c

Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 9083028-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Nov 24, 2024
@jartes jartes moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Nov 26, 2024
@jartes
Copy link

jartes commented Nov 26, 2024

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
Image

📌 ACTIONS

  • Triaged

📌 Message to Author
@supernovia Thanks for reporting this one!

@Automattic/t-rex This is coming from a Customer Report. Please, can you take a look? Thank you!

@iamtakashi
Copy link
Contributor

The issue has been fixed in #8463. It will be deployed to dotcom shortly (likely tomorrow).

@iamtakashi
Copy link
Contributor

The fix has been deployed to dotcom. I can confirm that the slideshow works fine now.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. Needs triage [Platform] Simple [Pri] Normal [Status] Auto-allocated [Theme] Common [Type] Bug Something isn't working
Development

Successfully merging a pull request may close this issue.

4 participants