Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define variable types, declare strict types, WordPress coding standard #157

Closed
26 tasks done
gudmdharalds opened this issue Apr 13, 2021 · 0 comments · Fixed by #272
Closed
26 tasks done

Define variable types, declare strict types, WordPress coding standard #157

gudmdharalds opened this issue Apr 13, 2021 · 0 comments · Fixed by #272
Assignees
Milestone

Comments

@gudmdharalds
Copy link
Contributor

gudmdharalds commented Apr 13, 2021

The code needs a bit of clean up in a few areas. This issue collects these and links to the appropriate issues/pull requests which resolve these issues.

The clean up involves:

  • Currently only part of the code uses strict variable types. All the code should use strict variable types, as it is safer.
  • declare(strict_types=1); should be used in all files.
  • All files should comply with the WordPress coding standard.

The above needs to be applied to the following files:

Unit tests are covered in #244.

@gudmdharalds gudmdharalds changed the title Define variable types Define variable types, declare strict types Jan 27, 2022
@gudmdharalds gudmdharalds changed the title Define variable types, declare strict types Define variable types, declare strict types, WordPress coding standard Feb 14, 2022
@gudmdharalds gudmdharalds added this to the 1.2.4 milestone May 17, 2022
@gudmdharalds gudmdharalds self-assigned this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant