You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Auto-approval functionality needs restructuring so to provide more consistency. vip-go-ci needs to keep a record of approved files per pull request processed.
Background of feature request
Currently, vip-go-ci relies on file-names for auto-approvals. Hence, when a file is found to be auto-approvable, it is added to an array of approved files. However, this can be problematic, for example when multiple pull requests are being processed which make different changes to the auto-approved files: In one pull request, changes to one file are trivial, but much larger in an other one. This can cause problems, though it is rare.
Description of feature
To improve this vip-go-ci needs to keep a record of which files are approved per pull-request, and use it when approving each pull request.
The text was updated successfully, but these errors were encountered:
Feature request
Auto-approval functionality needs restructuring so to provide more consistency.
vip-go-ci
needs to keep a record of approved files per pull request processed.Background of feature request
Currently,
vip-go-ci
relies on file-names for auto-approvals. Hence, when a file is found to be auto-approvable, it is added to an array of approved files. However, this can be problematic, for example when multiple pull requests are being processed which make different changes to the auto-approved files: In one pull request, changes to one file are trivial, but much larger in an other one. This can cause problems, though it is rare.Description of feature
To improve this
vip-go-ci
needs to keep a record of which files are approved per pull-request, and use it when approving each pull request.The text was updated successfully, but these errors were encountered: